Message ID | 20180102143410.13261-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Herbert Xu |
Headers | show |
Hi Colin, On Tue, Jan 02, 2018 at 02:34:10PM +0000, Colin King wrote: > > /* Called with ring's lock taken */ > -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring, > - int reqs) > +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, > + int ring, int reqs) Alignment should match open parenthesis, one space is missing. Otherwise, looks good to me. Thanks! Antoine
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 0d685be75241..e3745139644b 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -432,8 +432,8 @@ static int safexcel_hw_init(struct safexcel_crypto_priv *priv) } /* Called with ring's lock taken */ -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring, - int reqs) +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, + int ring, int reqs) { int coal = min_t(int, reqs, EIP197_MAX_BATCH_SZ);