diff mbox

crypto: tcrypt - free xoutbuf instead of axbuf

Message ID 20180102154304.14523-1-colin.king@canonical.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Colin King Jan. 2, 2018, 3:43 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

There seems to be a cut-n-paste bug with the name of the buffer being
free'd, xoutbuf should be used instead of axbuf.

Detected by CoverityScan, CID#1463420 ("Copy-paste error")

Fixes: 427988d981c4 ("crypto: tcrypt - add multibuf aead speed test")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 crypto/tcrypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Herbert Xu Jan. 12, 2018, 12:23 p.m. UTC | #1 
On Tue, Jan 02, 2018 at 03:43:04PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There seems to be a cut-n-paste bug with the name of the buffer being
> free'd, xoutbuf should be used instead of axbuf.
> 
> Detected by CoverityScan, CID#1463420 ("Copy-paste error")
> 
> Fixes: 427988d981c4 ("crypto: tcrypt - add multibuf aead speed test")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied.  Thanks.
diff mbox

Patch

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index f61d2f40dd90..14213a096fd2 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -298,7 +298,7 @@  static void test_mb_aead_speed(const char *algo, int enc, int secs,
 	for (i = 0; i < num_mb; ++i)
 		if (testmgr_alloc_buf(data[i].xoutbuf)) {
 			while (i--)
-				testmgr_free_buf(data[i].axbuf);
+				testmgr_free_buf(data[i].xoutbuf);
 			goto out_free_axbuf;
 		}