From patchwork Tue Feb 6 21:20:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Savkov X-Patchwork-Id: 10204141 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 88CDF60247 for ; Tue, 6 Feb 2018 21:20:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D4A5205FD for ; Tue, 6 Feb 2018 21:20:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71EDE288A3; Tue, 6 Feb 2018 21:20:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 29621205FD for ; Tue, 6 Feb 2018 21:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbeBFVUi (ORCPT ); Tue, 6 Feb 2018 16:20:38 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:39697 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753971AbeBFVUg (ORCPT ); Tue, 6 Feb 2018 16:20:36 -0500 Received: by mail-wr0-f194.google.com with SMTP id f6so3462350wra.6; Tue, 06 Feb 2018 13:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hVtG3jfvyM1oZP/Xy4MFLTrfC1YYQBXb+Q3XAZEC7NM=; b=mkNHgR7dOQt/tAtIbHu778yH4LxfB1erpF9utsUoi8aGturtRjHbt/H/94zV5un2Rm 8U0wveVYR+cTZC0vY5EUTKKRQcmZPMuz25fP7UzI5BmNClBuMr6W3Ar0Wdujo8tOn/3g DU/6IPUpy8t5nHeEaZZryNfx3RrNAr2lRaVxXL+RFlGPUt+O2OtnSbzOKD3ut5IEy8fH rWKh1wk6SAZ2Z6bZrajxREl2nB6F9+dVCXAQucys9uTpNZR+1Ij7E+PGPYtiDBDhpuO3 yACXIPRqN4TAInFEl//PPHEfkFh7b//awnHeEyp5lZ/TqpZKUZUl0ZADkoL4v2BeSn6y BEUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hVtG3jfvyM1oZP/Xy4MFLTrfC1YYQBXb+Q3XAZEC7NM=; b=ite/SSmPJQUJ3MecHCKOrrykw6XAMFlgXeU2yxUgc4feP5rkDb91BRUMjZRbAlWQ8e ziu88G09N21S/68XCDLMHayQCewZ2n3yADcMZ7uUIj4jKhw2aaqGQSk5juGNscyiwWQI 00YwSNR/fITfjgLAHs+6wMT89VknY6ZVc05olNahfegjtcjM2Pl2Rs3hugnedfutmhL6 OU1rltDKQ/iTSTprg9o2ylZ+oV+enDFDTy6VWpqcmGTiIlJ28hAUytKtWIO4UR3gl8ur MvBYnOr/BT7YyWGFHQolw4s6k5Sh2ZHQWPNjr7/b2rauQ3bwD1y9vXGDsMvhAx43HVFL H5hg== X-Gm-Message-State: APf1xPAU3n6KZf2h5Fjaqksl/gHH/7j362qhcbmRNksRRd9uCE6FeBku pw3ZoC8pXQ5Zm5WqWlM5W04= X-Google-Smtp-Source: AH8x227kI1YlKOPvJ92M+/h2rwAEJBAKeEIPPt2z8d6B5L2BNbbmpFlo6KsvpRfbLuKM1+BLKF6n3Q== X-Received: by 10.223.139.131 with SMTP id o3mr3434449wra.279.1517952035481; Tue, 06 Feb 2018 13:20:35 -0800 (PST) Received: from localhost ([176.74.128.122]) by smtp.gmail.com with ESMTPSA id 56sm6842056wrt.23.2018.02.06.13.20.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Feb 2018 13:20:34 -0800 (PST) From: Artem Savkov To: Corentin Labbe Cc: Herbert Xu , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Artem Savkov Subject: [PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate Date: Tue, 6 Feb 2018 22:20:22 +0100 Message-Id: <20180206212022.1309-3-artem.savkov@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180206212022.1309-1-artem.savkov@gmail.com> References: <20180206212022.1309-1-artem.savkov@gmail.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov --- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-prng.c b/drivers/crypto/sunxi-ss/sun4i-ss-prng.c index 5754e0b92fb0..63d636424161 100644 --- a/drivers/crypto/sunxi-ss/sun4i-ss-prng.c +++ b/drivers/crypto/sunxi-ss/sun4i-ss-prng.c @@ -28,7 +28,7 @@ int sun4i_ss_prng_generate(struct crypto_rng *tfm, const u8 *src, algt = container_of(alg, struct sun4i_ss_alg_template, alg.rng); ss = algt->ss; - spin_lock(&ss->slock); + spin_lock_bh(&ss->slock); writel(mode, ss->base + SS_CTL); @@ -51,6 +51,6 @@ int sun4i_ss_prng_generate(struct crypto_rng *tfm, const u8 *src, } writel(0, ss->base + SS_CTL); - spin_unlock(&ss->slock); + spin_unlock_bh(&ss->slock); return 0; }