diff mbox

[9/9] crypto: talitos - don't leak pointers to authenc keys

Message ID 20180321170057.5128-10-tudor.ambarus@microchip.com (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show

Commit Message

Tudor Ambarus March 21, 2018, 5 p.m. UTC 
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/crypto/talitos.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Christophe Leroy March 22, 2018, 7:08 a.m. UTC | #1 
Le 21/03/2018 à 18:00, Tudor Ambarus a écrit :
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>

> ---
>   drivers/crypto/talitos.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index 447cb8b..c92efc7 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -904,10 +904,12 @@ static int aead_setkey(struct crypto_aead *authenc,
>   	ctx->dma_key = dma_map_single(dev, ctx->key, ctx->keylen,
>   				      DMA_TO_DEVICE);
>   
> +	memzero_explicit(&keys, sizeof(keys));
>   	return 0;
>   
>   badkey:
>   	crypto_aead_set_flags(authenc, CRYPTO_TFM_RES_BAD_KEY_LEN);
> +	memzero_explicit(&keys, sizeof(keys));
>   	return -EINVAL;
>   }
>   
>
diff mbox

Patch

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index 447cb8b..c92efc7 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -904,10 +904,12 @@  static int aead_setkey(struct crypto_aead *authenc,
 	ctx->dma_key = dma_map_single(dev, ctx->key, ctx->keylen,
 				      DMA_TO_DEVICE);
 
+	memzero_explicit(&keys, sizeof(keys));
 	return 0;
 
 badkey:
 	crypto_aead_set_flags(authenc, CRYPTO_TFM_RES_BAD_KEY_LEN);
+	memzero_explicit(&keys, sizeof(keys));
 	return -EINVAL;
 }