From patchwork Tue Jun 5 13:49:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10448335 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8BAFC60234 for ; Tue, 5 Jun 2018 13:50:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CD9829494 for ; Tue, 5 Jun 2018 13:50:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71ED9294A6; Tue, 5 Jun 2018 13:50:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1742D29494 for ; Tue, 5 Jun 2018 13:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942AbeFENue (ORCPT ); Tue, 5 Jun 2018 09:50:34 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:44944 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbeFENuc (ORCPT ); Tue, 5 Jun 2018 09:50:32 -0400 Received: by mail-lf0-f66.google.com with SMTP id 36-v6so3678248lfr.11 for ; Tue, 05 Jun 2018 06:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Rh3sCnI3vLegjKnR3N/27pCwp0NKmzxY+Xf21CxeW5I=; b=HyTFZSlk+sFDyh2U5pdQcTW4qs+oJrD1DBsTpbQZ9zc5BnFUHZuD8WgDuxN+o80++2 tMmVoNnLC8UC9WURRfptlhGuwdKiLYCqT+QbgukLSEYSG68sZirHyS3FmpTARxPC87I+ Y1zvnG52PRaGGTjCW7V1lKsRvh/Edhf5B5YBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Rh3sCnI3vLegjKnR3N/27pCwp0NKmzxY+Xf21CxeW5I=; b=q6xoqUEnp4cfVKXO6nkQtn+zVdDhmG+PHI2lE5GPiS9T/rf1Raupf8sEIIyDRekVe/ Hwje8HmPeB8Ecs/5UfoWHtMrt8tdpNzmwuTI30LymVgkasTovUbDC4zc4v/v9h6tvHkH ZP0GK3llFlYXYwcUERKkgpJO6negP3k5RiBg1MuNrMd9x2Pr9FooQJ0z848vw/9+uRgs KrNdG+l6J0/3ohaX1eQq7TEgUeSylkPN7DV3oYJi1Mhh1V3fsoGuBM9EHoQtPOGjMFCl dxUYyE4UV0B2UiNtkgqOiVeXD4JkwBdsHOVic1tNxSIuiDwGz5mDGoXPXvqlgt+3nCYl 7Vlw== X-Gm-Message-State: APt69E3R9a6BLjA2wGGv4ARkSxtg/AeLQbUJ6WC2RaouvcVPrOm7IZQ3 ayIz0kGfV0b4I97a0BJwN1qNgrT8460= X-Google-Smtp-Source: ADUXVKIMUXw9kExVLQ88BQSIO2Ai7tYXRZWz9aWgTuRA+Yrm1z72oueotgSkdiYtfHOEA3OVKHrR1A== X-Received: by 2002:a19:5d54:: with SMTP id p20-v6mr1789606lfj.21.1528206631352; Tue, 05 Jun 2018 06:50:31 -0700 (PDT) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id x72-v6sm5201092lfi.52.2018.06.05.06.50.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jun 2018 06:50:30 -0700 (PDT) From: Linus Walleij To: linux-crypto@vger.kernel.org, Herbert Xu , Tudor Ambarus Cc: Linus Walleij Subject: [PATCH 5/9] crypto: atmel-ecc: Create a config word reader Date: Tue, 5 Jun 2018 15:49:46 +0200 Message-Id: <20180605134950.6605-5-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180605134950.6605-1-linus.walleij@linaro.org> References: <20180605134950.6605-1-linus.walleij@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rewrite the function atmel_ecc_init_read_cmd() into a more general atmel_ecc_init_read_config_word() function to read any word from the configuration zone, and use this parameterized with what we want to read out. Signed-off-by: Linus Walleij --- drivers/crypto/atmel-ecc.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index f1f422385a91..d89b69d228ac 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -136,16 +136,13 @@ static void atmel_ecc_checksum(struct atmel_ecc_cmd *cmd) *crc16 = atmel_ecc_crc16(0, data, len); } -static void atmel_ecc_init_read_cmd(struct atmel_ecc_cmd *cmd) +static void atmel_ecc_init_read_config_word(struct atmel_ecc_cmd *cmd, + u16 config_word) { cmd->word_addr = COMMAND; cmd->opcode = OPCODE_READ; - /* - * Read the word from Configuration zone that contains the lock bytes - * (UserExtra, Selector, LockValue, LockConfig). - */ cmd->param1 = CONFIG_ZONE; - cmd->param2 = CONFIG_ZONE_FOOTER; + cmd->param2 = config_word; cmd->count = READ_COUNT; atmel_ecc_checksum(cmd); @@ -633,7 +630,7 @@ static int device_sanity_check(struct i2c_client *client) if (!cmd) return -ENOMEM; - atmel_ecc_init_read_cmd(cmd); + atmel_ecc_init_read_config_word(cmd, CONFIG_ZONE_FOOTER); ret = atmel_ecc_send_receive(client, cmd); if (ret) {