diff mbox series

[PATCHv2] crypto: caam - fixed handling of sg list

Message ID 20190201053812.71275-1-pankaj.gupta@nxp.com (mailing list archive)
State Superseded
Delegated to: Herbert Xu
Headers show
Series [PATCHv2] crypto: caam - fixed handling of sg list | expand

Commit Message

Pankaj Gupta Feb. 1, 2019, 5:50 a.m. UTC
when the source sg contains more than 1 fragment and
destination sg contains 1 fragment, the caam driver
mishandle the buffers to be sent to caam.

Fixes: f2147b88b2b1 ("crypto: caam - Convert GCM to new AEAD interface")
Cc: <stable@vger.kernel.org> # 4.2+
Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
Signed-off-by: Arun Pathak <arun.pathak@nxp.com>
---
 drivers/crypto/caam/caamalg.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Horia Geanta Feb. 1, 2019, 6:51 a.m. UTC | #1
On 2/1/2019 7:50 AM, Pankaj Gupta wrote:
> when the source sg contains more than 1 fragment and
> destination sg contains 1 fragment, the caam driver
> mishandle the buffers to be sent to caam.
> 
> Fixes: f2147b88b2b1 ("crypto: caam - Convert GCM to new AEAD interface")
> Cc: <stable@vger.kernel.org> # 4.2+
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> Signed-off-by: Arun Pathak <arun.pathak@nxp.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>

Thanks,
Horia
diff mbox series

Patch

diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c
index 2ec6e8cbf026..49f436230fb8 100644
--- a/drivers/crypto/caam/caamalg.c
+++ b/drivers/crypto/caam/caamalg.c
@@ -1056,6 +1056,7 @@  static void init_aead_job(struct aead_request *req,
 	if (unlikely(req->src != req->dst)) {
 		if (edesc->dst_nents == 1) {
 			dst_dma = sg_dma_address(req->dst);
+			out_options = 0;
 		} else {
 			dst_dma = edesc->sec4_sg_dma +
 				  sec4_sg_index *