From patchwork Mon May 20 16:52:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Biggers X-Patchwork-Id: 10951893 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9DA4876 for ; Mon, 20 May 2019 16:53:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 890B52889E for ; Mon, 20 May 2019 16:53:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79B8D288A2; Mon, 20 May 2019 16:53:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23F4D2889E for ; Mon, 20 May 2019 16:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731488AbfETQxQ (ORCPT ); Mon, 20 May 2019 12:53:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:55158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388746AbfETQxQ (ORCPT ); Mon, 20 May 2019 12:53:16 -0400 Received: from ebiggers-linuxstation.mtv.corp.google.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BCE64216B7; Mon, 20 May 2019 16:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558371195; bh=Z2o4G3D5YiDXTU6glE+pKthV1dES/iVyp7OFnedfRRg=; h=From:To:Cc:Subject:Date:From; b=qn6ydxZ+TEAJI5JSghM6q0GQFgFvse3FpBvTOLdzQbekjtuDYM0zYy0Y8u4khKJuS 1V+5lg0VUIL2+u9GyuhbYVuAoEVR+mF3kGZIhfPaXYbtcb5eqaVb+waoJipw8bMwO3 SlbkOr+uD+hsfBPf0PdLXNvQ9b++NRDilP1Lm/Dc= From: Eric Biggers To: linux-crypto@vger.kernel.org, Herbert Xu Cc: Steffen Klassert , "David S . Miller" Subject: [PATCH] crypto: echainiv - change to 'default n' Date: Mon, 20 May 2019 09:52:07 -0700 Message-Id: <20190520165207.168925-1-ebiggers@kernel.org> X-Mailer: git-send-email 2.21.0.1020.gf2820cf01a-goog MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Eric Biggers echainiv is the only algorithm or template in the crypto API that is enabled by default. But there doesn't seem to be a good reason for it. And it pulls in a lot of stuff as dependencies, like AEAD support and a "NIST SP800-90A DRBG" including HMAC-SHA256. The commit which made it default 'm', commit 3491244c6298 ("crypto: echainiv - Set Kconfig default to m"), mentioned that it's needed for IPsec. However, later commit 32b6170ca59c ("ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV") made the IPsec kconfig options select it. So, remove the 'default m'. Signed-off-by: Eric Biggers --- crypto/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/crypto/Kconfig b/crypto/Kconfig index af8c6b4e6a83a..1062e1031f73a 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -428,7 +428,6 @@ config CRYPTO_ECHAINIV select CRYPTO_NULL select CRYPTO_RNG_DEFAULT select CRYPTO_MANAGER - default m help This IV generator generates an IV based on the encryption of a sequence number xored with a salt. This is the default