| Message ID | 20190601144943.126995-1-alex_y_xu@yahoo.ca (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: ux500 - fix license comment syntax error | expand |
On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote: > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing > separator. Stop. > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with > SPDX - rule 194") > > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> > --- > drivers/crypto/ux500/cryp/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ugh, sorry about that. Will go queue that up right now. thanks, greg k-h
On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote: > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing > separator. Stop. > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194") > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> > --- > drivers/crypto/ux500/cryp/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Also, how did 0-day not catch this? Is this an odd configuration that it can not build? thanks, greg k-h
Quoting Greg KH (2019-06-01 16:29:07) > On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote: > > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing > > separator. Stop. > > > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194") > > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> > > --- > > drivers/crypto/ux500/cryp/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Also, how did 0-day not catch this? Is this an odd configuration that > it can not build? I had to run "make clean" to get the error.
On Sun, Jun 2, 2019 at 4:41 AM Alex Xu <alex_y_xu@yahoo.ca> wrote: > > Quoting Greg KH (2019-06-01 16:29:07) > > On Sat, Jun 01, 2019 at 10:49:43AM -0400, Alex Xu (Hello71) wrote: > > > Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing > > > separator. Stop. > > > > > > Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194") > > > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> > > > --- > > > drivers/crypto/ux500/cryp/Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Also, how did 0-day not catch this? Is this an odd configuration that > > it can not build? > > I had to run "make clean" to get the error. I think this copyright block is ugly. # SPDX-License-Identifier: GPL-2.0-only # # Copyright (C) ST-Ericsson SA 2010 # Author: shujuan.chen@stericsson.com for ST-Ericsson. looks nicer IMHO.
diff --git a/drivers/crypto/ux500/cryp/Makefile b/drivers/crypto/ux500/cryp/Makefile index a90b50597e5c..3e67531f484c 100644 --- a/drivers/crypto/ux500/cryp/Makefile +++ b/drivers/crypto/ux500/cryp/Makefile @@ -2,7 +2,7 @@ #/* # * Copyright (C) ST-Ericsson SA 2010 # * Author: shujuan.chen@stericsson.com for ST-Ericsson. - */ +# */ ccflags-$(CONFIG_CRYPTO_DEV_UX500_DEBUG) += -DDEBUG
Causes error: drivers/crypto/ux500/cryp/Makefile:5: *** missing separator. Stop. Fixes: af873fcecef5 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194") Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> --- drivers/crypto/ux500/cryp/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)