From patchwork Tue Mar 24 00:13:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 11454313 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3CBCC139A for ; Tue, 24 Mar 2020 00:16:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DF0320714 for ; Tue, 24 Mar 2020 00:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585008965; bh=KYcU9DxUP7tLrJr9ClQOiTH7DZVvaOFzGYQXSSQnqQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ED++VLA6QudzZ5XrkG+tWopCJLvl7J6tYKzY4KNp76MDK9kdaE0l74lWPY5rA87RY vyWsFpdChqR7PyAxBr2CcqORqdfdfbYrUZHlkofMbgF0gbGc0znJCEL+uxIkgxSXM9 Qekqy/gySp53yNKnAL0ka5FHfHcRUB/23k2M+NLY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727452AbgCXAQB (ORCPT ); Mon, 23 Mar 2020 20:16:01 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:30072 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727518AbgCXAQB (ORCPT ); Mon, 23 Mar 2020 20:16:01 -0400 Received: from grover.flets-west.jp (softbank126093102113.bbtec.net [126.93.102.113]) (authenticated) by conuserg-09.nifty.com with ESMTP id 02O0EHno026701; Tue, 24 Mar 2020 09:14:19 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com 02O0EHno026701 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1585008860; bh=yffm46YFmxaSr9rCwfC2bdmSbJGZM843ty/T2DMTN1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2btJ0VUSOfzxMSFB6mKC64/zSHX/dZOhHD3x4eMgKM1uvSaNVQvU8sUOqDoWQ93v6 boBziA8N6Qqy7t4lkHYWs1LCT9vOQUMn1louCqsXHd8veC5dTPBWrDBTaKQoPfqp7R LJgD4oR5GOK/C9oOEJmAewKMUOHPZw1D45RA77zQGC2rt1FFTxIhbpzi+FMtJwXmPB k8TGRO4tIG3yBcoFArDqqHAvSo02EaxuUttGMAYqZwIayBzzBXwfIqVWSltySN47fY LX76fW0MfHHLjXfBkhDJPwYig0qp3135Xuqme08LRBJ6f/8ujiygzu8d55aB/MdtWH rvUP+vs6Wqy8Q== X-Nifty-SrcIP: [126.93.102.113] From: Masahiro Yamada To: x86@kernel.org, Ingo Molnar , Thomas Gleixner , Borislav Petkov , "H . Peter Anvin" , linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Jason A . Donenfeld" , Masahiro Yamada , Jim Kukunas , NeilBrown , Yuanhan Liu Subject: [PATCH v2 1/9] lib/raid6/test: fix build on distros whose /bin/sh is not bash Date: Tue, 24 Mar 2020 09:13:50 +0900 Message-Id: <20200324001358.4520-2-masahiroy@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200324001358.4520-1-masahiroy@kernel.org> References: <20200324001358.4520-1-masahiroy@kernel.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org You can test raid6 library code from user-space, like this: $ cd lib/raid6/test $ make The command in $(shell ...) function is evaluated by /bin/sh by default. (or, you can change the default shell by setting 'SHELL' in Makefile) Currently '>&/dev/null' is used to sink both stdout and stderr. Because this code is bash-ism, it only works when /bin/sh is a symbolic link to bash (this is the case on RHEL etc.) This does not work on Ubuntu where /bin/sh is a symbolic link to dash. I see lots of /bin/sh: 1: Syntax error: Bad fd number and warning "your version of binutils lacks ... support" Replace it with portable '>/dev/null 2>&1'. Fixes: 4f8c55c5ad49 ("lib/raid6: build proper files on corresponding arch") Signed-off-by: Masahiro Yamada Acked-by: H. Peter Anvin (Intel) --- Changes in v2: - New patch lib/raid6/test/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile index 3ab8720aa2f8..b9e6c3648be1 100644 --- a/lib/raid6/test/Makefile +++ b/lib/raid6/test/Makefile @@ -35,13 +35,13 @@ endif ifeq ($(IS_X86),yes) OBJS += mmx.o sse1.o sse2.o avx2.o recov_ssse3.o recov_avx2.o avx512.o recov_avx512.o CFLAGS += $(shell echo "pshufb %xmm0, %xmm0" | \ - gcc -c -x assembler - >&/dev/null && \ + gcc -c -x assembler - >/dev/null 2>&1 && \ rm ./-.o && echo -DCONFIG_AS_SSSE3=1) CFLAGS += $(shell echo "vpbroadcastb %xmm0, %ymm1" | \ - gcc -c -x assembler - >&/dev/null && \ + gcc -c -x assembler - >/dev/null 2>&1 && \ rm ./-.o && echo -DCONFIG_AS_AVX2=1) CFLAGS += $(shell echo "vpmovm2b %k1, %zmm5" | \ - gcc -c -x assembler - >&/dev/null && \ + gcc -c -x assembler - >/dev/null 2>&1 && \ rm ./-.o && echo -DCONFIG_AS_AVX512=1) else ifeq ($(HAS_NEON),yes) OBJS += neon.o neon1.o neon2.o neon4.o neon8.o recov_neon.o recov_neon_inner.o