From patchwork Tue Apr 21 05:12:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Rothwell X-Patchwork-Id: 11500465 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D5CB92C for ; Tue, 21 Apr 2020 05:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 041E7214AF for ; Tue, 21 Apr 2020 05:12:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="rd86yj9C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725902AbgDUFMr (ORCPT ); Tue, 21 Apr 2020 01:12:47 -0400 Received: from ozlabs.org ([203.11.71.1]:54217 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbgDUFMr (ORCPT ); Tue, 21 Apr 2020 01:12:47 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 495sBz2ljkz9sP7; Tue, 21 Apr 2020 15:12:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1587445964; bh=kRYwJ8+v3TDEL7Vf+kKyDQ72TRLTgSM6bWAyzSYbWWM=; h=Date:From:To:Cc:Subject:From; b=rd86yj9Co/DZxjkRu7cx1Y3kiPL9W0qnry1rD2m6G3SGX/Ujw/Nr999jKv4VS5iqp o9F981Ymv2LgHcASgnX6pBTH+LsPC4HY41qSoF/rCmxnllhtKFYrSiamTv+tAasNxx tiAEIR7yKNqZ1zAaKMUWdTCGADljAnlQsxWSAtCESwm03X6isBXH/b4/mE+f7W4kwa b4ccBTUT1xcRv3sRGllAKYuNb1GBS2FxGaP2h+XNTafkr1GZTtBlTY+wA70cmFJSn9 xbq9EBsS4vHkESQoJ60Gn64Sw1BfT05+sX5nXcjuyI/DwnLt9bnekTJ2Mi+lAJ3qj4 32fvfeCSFdTGQ== Date: Tue, 21 Apr 2020 15:12:40 +1000 From: Stephen Rothwell To: Herbert Xu , Linux Crypto List Cc: Linux Next Mailing List , Linux Kernel Mailing List , Shukun Tan , Zhou Wang , Zaibo Xu Subject: linux-next: build failure after merge of the crypto tree Message-ID: <20200421151240.4dfc679a@canb.auug.org.au> MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi all, After merging the crypto tree, today's linux-next build (powerpc allyesconfig) failed like this: WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && (ARM64 || COMPILE_TEST [=y]) && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && ACPI Selected by [y]: - CRYPTO_DEV_HISI_SEC2 [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y]) - CRYPTO_DEV_HISI_ZIP [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y]) && (!CPU_BIG_ENDIAN [=y] || COMPILE_TEST [=y]) && (UACCE [=y] || UACCE [=y]=n) - CRYPTO_DEV_HISI_HPRE [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y]) drivers/crypto/hisilicon/qm.c: In function 'qm_soft_reset': drivers/crypto/hisilicon/qm.c:2915:7: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration] 2915 | s = acpi_evaluate_integer(ACPI_HANDLE(&pdev->dev), | ^~~~~~~~~~~~~~~~~~~~~ | acpi_evaluate_object Caused by commit 6c6dd5802c2d ("crypto: hisilicon/qm - add controller reset interface") Unfortunately not fixed by commit f88480e300ac ("crypto: hisilicon/qm - fix build failure with ACPI off") [the moral is "don't select symbols that have dependencies" :-( ] I have added the following patch for today From: Stephen Rothwell Date: Tue, 21 Apr 2020 14:56:49 +1000 Subject: [PATCH] crypto: hisilicon/qm add more ACPI dependencies due to the selects of CRYPTO_DEV_HISI_QM which now depends on ACPI Signed-off-by: Stephen Rothwell --- drivers/crypto/hisilicon/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig index 99e962e39f36..9c3b3ca815e6 100644 --- a/drivers/crypto/hisilicon/Kconfig +++ b/drivers/crypto/hisilicon/Kconfig @@ -29,6 +29,7 @@ config CRYPTO_DEV_HISI_SEC2 depends on PCI && PCI_MSI depends on UACCE || UACCE=n depends on ARM64 || (COMPILE_TEST && 64BIT) + depends on ACPI help Support for HiSilicon SEC Engine of version 2 in crypto subsystem. It provides AES, SM4, and 3DES algorithms with ECB @@ -53,6 +54,7 @@ config CRYPTO_DEV_HISI_ZIP depends on ARM64 || (COMPILE_TEST && 64BIT) depends on !CPU_BIG_ENDIAN || COMPILE_TEST depends on UACCE || UACCE=n + depends on ACPI select CRYPTO_DEV_HISI_QM help Support for HiSilicon ZIP Driver @@ -62,6 +64,7 @@ config CRYPTO_DEV_HISI_HPRE depends on PCI && PCI_MSI depends on UACCE || UACCE=n depends on ARM64 || (COMPILE_TEST && 64BIT) + depends on ACPI select CRYPTO_DEV_HISI_QM select CRYPTO_DH select CRYPTO_RSA