| Message ID | 20200506144719.3725-1-ayush.sawal@chelsio.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [net-next] Revert "crypto: chelsio - Inline single pdu only" | expand |
From: Ayush Sawal <ayush.sawal@chelsio.com> Date: Wed, 6 May 2020 20:17:19 +0530 > This reverts commit 27c6feb0fb33a665a746346e76714826a5be5d10. > > For ipsec offload the chelsio's ethernet driver expects a single mtu > sized packet. > > But when ipsec traffic is running using iperf, most of the packets in > that traffic are gso packets(large sized skbs) because GSO is enabled by > default in TCP, due to this commit 0a6b2a1dc2a2 ("tcp: switch to GSO > being always on"), so chcr_ipsec_offload_ok() receives a gso > skb(with gso_size non zero). > > Due to the check in chcr_ipsec_offload_ok(), this function returns false > for most of the packet, then ipsec offload is skipped and the skb goes > out taking the coprocessor path which reduces the bandwidth for inline > ipsec. > > If this check is removed then for most of the packets(large sized skbs) > the chcr_ipsec_offload_ok() returns true and then as GSO is on, the > segmentation of the packet happens in the kernel and then finally the > driver_xmit is called, which receives a segmented mtu sized packet which > is what the driver expects for ipsec offload. So this case becomes > unnecessary here, therefore removing it. > > Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com> Applied.
diff --git a/drivers/crypto/chelsio/chcr_ipsec.c b/drivers/crypto/chelsio/chcr_ipsec.c index 9fd3b9d1ec2f..d25689837b26 100644 --- a/drivers/crypto/chelsio/chcr_ipsec.c +++ b/drivers/crypto/chelsio/chcr_ipsec.c @@ -294,9 +294,6 @@ static bool chcr_ipsec_offload_ok(struct sk_buff *skb, struct xfrm_state *x) if (ipv6_ext_hdr(ipv6_hdr(skb)->nexthdr)) return false; } - /* Inline single pdu */ - if (skb_shinfo(skb)->gso_size) - return false; return true; }
This reverts commit 27c6feb0fb33a665a746346e76714826a5be5d10. For ipsec offload the chelsio's ethernet driver expects a single mtu sized packet. But when ipsec traffic is running using iperf, most of the packets in that traffic are gso packets(large sized skbs) because GSO is enabled by default in TCP, due to this commit 0a6b2a1dc2a2 ("tcp: switch to GSO being always on"), so chcr_ipsec_offload_ok() receives a gso skb(with gso_size non zero). Due to the check in chcr_ipsec_offload_ok(), this function returns false for most of the packet, then ipsec offload is skipped and the skb goes out taking the coprocessor path which reduces the bandwidth for inline ipsec. If this check is removed then for most of the packets(large sized skbs) the chcr_ipsec_offload_ok() returns true and then as GSO is on, the segmentation of the packet happens in the kernel and then finally the driver_xmit is called, which receives a segmented mtu sized packet which is what the driver expects for ipsec offload. So this case becomes unnecessary here, therefore removing it. Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com> --- drivers/crypto/chelsio/chcr_ipsec.c | 3 --- 1 file changed, 3 deletions(-)