| Message ID | 20200619213347.27826-2-horia.geanta@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | hwrng: add support for i.MX6 rngb | expand |
Hi Horia, On Fri, Jun 19, 2020 at 6:34 PM Horia Geantă <horia.geanta@nxp.com> wrote: > > rng DT node was added without a compatible string. > > i.MX driver for RNGC (drivers/char/hw_random/imx-rngc.c) also claims > support for RNGB, and is currently used for i.MX25. > > Let's used this driver also for RNGB block in i.MX6SL. "Let's use" > > Fixes: e29fe21cff96 ("ARM: dts: add device tree source for imx6sl SoC") > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > --- > arch/arm/boot/dts/imx6sl.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi > index 911d8cf77f2c..1f0f250ee175 100644 > --- a/arch/arm/boot/dts/imx6sl.dtsi > +++ b/arch/arm/boot/dts/imx6sl.dtsi > @@ -939,8 +939,10 @@ > }; > > rngb: rngb@21b4000 { > + compatible = "fsl,imx25-rngb"; Better to use: compatible = "fsl,imx6sl-rngb","fsl,imx25-rngb"; and document fsl,imx6sl-rngb
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 911d8cf77f2c..1f0f250ee175 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -939,8 +939,10 @@ }; rngb: rngb@21b4000 { + compatible = "fsl,imx25-rngb"; reg = <0x021b4000 0x4000>; interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks IMX6SL_CLK_DUMMY>; }; weim: weim@21b8000 {
rng DT node was added without a compatible string. i.MX driver for RNGC (drivers/char/hw_random/imx-rngc.c) also claims support for RNGB, and is currently used for i.MX25. Let's used this driver also for RNGB block in i.MX6SL. Fixes: e29fe21cff96 ("ARM: dts: add device tree source for imx6sl SoC") Signed-off-by: Horia Geantă <horia.geanta@nxp.com> --- arch/arm/boot/dts/imx6sl.dtsi | 2 ++ 1 file changed, 2 insertions(+)