| Message ID | 20200701200950.30314-3-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | drivers/char: Constify static variables | expand |
On Wed, Jul 1, 2020 at 11:48 PM Rikard Falkeborn <rikard.falkeborn@gmail.com> wrote: > > nmk_rng_ids[] is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: > text data bss dec hex filename > 652 216 4 872 368 drivers/char/hw_random/nomadik-rng.o > > After: > text data bss dec hex filename > 676 192 4 872 368 drivers/char/hw_random/nomadik-rng.o Moving 24 bytes into the .rodata section is probably not a worth the change, but the patch is correct and I agree this should be .rodata anway. > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Acked-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/char/hw_random/nomadik-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/hw_random/nomadik-rng.c b/drivers/char/hw_random/nomadik-rng.c > index 74ed29f42e4f..b0ded41eb865 100644 > --- a/drivers/char/hw_random/nomadik-rng.c > +++ b/drivers/char/hw_random/nomadik-rng.c > @@ -76,7 +76,7 @@ static int nmk_rng_remove(struct amba_device *dev) > return 0; > } > > -static struct amba_id nmk_rng_ids[] = { > +static const struct amba_id nmk_rng_ids[] = { > { > .id = 0x000805e1, > .mask = 0x000fffff, /* top bits are rev and cfg: accept all */ > -- > 2.27.0 >
diff --git a/drivers/char/hw_random/nomadik-rng.c b/drivers/char/hw_random/nomadik-rng.c index 74ed29f42e4f..b0ded41eb865 100644 --- a/drivers/char/hw_random/nomadik-rng.c +++ b/drivers/char/hw_random/nomadik-rng.c @@ -76,7 +76,7 @@ static int nmk_rng_remove(struct amba_device *dev) return 0; } -static struct amba_id nmk_rng_ids[] = { +static const struct amba_id nmk_rng_ids[] = { { .id = 0x000805e1, .mask = 0x000fffff, /* top bits are rev and cfg: accept all */
nmk_rng_ids[] is not modified and can be made const to allow the compiler to put it in read-only memory. Before: text data bss dec hex filename 652 216 4 872 368 drivers/char/hw_random/nomadik-rng.o After: text data bss dec hex filename 676 192 4 872 368 drivers/char/hw_random/nomadik-rng.o Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/char/hw_random/nomadik-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)