| Message ID | 20200723060908.50081-2-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [01/26] bpfilter: fix up a sparse annotation | expand |
On Thu, Jul 23, 2020 at 08:08:43AM +0200, Christoph Hellwig wrote: > The __user doesn't make sense when casting to an integer type, just > switch to a uintptr_t cast which also removes the need for the __force. Feel free to add my: Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> -- Luc
diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c index 2c31e82cb953af..3bac5820062af1 100644 --- a/net/bpfilter/bpfilter_kern.c +++ b/net/bpfilter/bpfilter_kern.c @@ -44,7 +44,7 @@ static int __bpfilter_process_sockopt(struct sock *sk, int optname, req.is_set = is_set; req.pid = current->pid; req.cmd = optname; - req.addr = (long __force __user)optval; + req.addr = (uintptr_t)optval; req.len = optlen; if (!bpfilter_ops.info.tgid) goto out;
The __user doesn't make sense when casting to an integer type, just switch to a uintptr_t cast which also removes the need for the __force. Signed-off-by: Christoph Hellwig <hch@lst.de> --- net/bpfilter/bpfilter_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)