| Message ID | 20210130225540.1639-2-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | None | expand |
On Sat, Jan 30, 2021 at 02:55:38PM -0800, Florian Fainelli wrote: > It is currently possible to build CONFIG_HW_RANDOM_PPC4XX=y with > CONFIG_HW_RANDOM=m which would lead to the inability of linking with > devm_hwrng_{register,unregister}. We cannot have the framework modular > and the consumer of that framework built-in, so make that dependency > explicit. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index e535f28a8028..c833ac08ea81 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -348,7 +348,7 @@ config CRYPTO_DEV_PPC4XX config HW_RANDOM_PPC4XX bool "PowerPC 4xx generic true random number generator support" - depends on CRYPTO_DEV_PPC4XX && HW_RANDOM + depends on CRYPTO_DEV_PPC4XX && HW_RANDOM=y default y help This option provides the kernel-side support for the TRNG hardware
It is currently possible to build CONFIG_HW_RANDOM_PPC4XX=y with CONFIG_HW_RANDOM=m which would lead to the inability of linking with devm_hwrng_{register,unregister}. We cannot have the framework modular and the consumer of that framework built-in, so make that dependency explicit. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)