From patchwork Thu Feb 4 11:09:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067057 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1BEC433E9 for ; Thu, 4 Feb 2021 11:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90EC564D9D for ; Thu, 4 Feb 2021 11:17:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235693AbhBDLRX (ORCPT ); Thu, 4 Feb 2021 06:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235620AbhBDLMT (ORCPT ); Thu, 4 Feb 2021 06:12:19 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F563C061220 for ; Thu, 4 Feb 2021 03:10:20 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id m1so2640631wml.2 for ; Thu, 04 Feb 2021 03:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SaJWQD4EKpGmPpCanTvsNZ7Bn2MtR7BiI9nKxNlqVtw=; b=U+WBo23B0peFGorO7gesn2YLEsU8eTQip1OggOGRWj1tPIbr8SwXLLk1casRK5oCnn wkWdjrLJKUtXzardMlzF4vwCmPlwj1cLOQoxfEGW++0ld+5uHLBWyCN5ko9hoTUckX+X uArTd51/R6O83F5TihJAeEchRufyzEB0S3wmgVSyBcEydwdWTYM5I/rDflMzWqkQqi53 9NOZ8rJCvTUn+25rZDqOLL289kDdHhGluWeno1A5xodiH1HDLi5RkgPSbKc5mpClIYvz JPzzOSL/SLa965FohBQyvskS+qj9B32WsihhrnY9rRdcE268GDj0rbquT3YAZOy01gh3 x4rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SaJWQD4EKpGmPpCanTvsNZ7Bn2MtR7BiI9nKxNlqVtw=; b=LBBCLoeCqfzO35Quso3XgPznx8psK8lp4UK5tHN3MJyG7CAtolMIxP3Nl5T2xke8II QI+jxfhbcpMO3C20TQhCFzIOU/xSgmi+zPWEMNdwOT9cXmiXUgdKohTuNFUyuGQHVxTI rvrUmCHah6UKfrnuXbVH9YF4byjQZtdCL+ZyZNfsSkkcB0/zVJ+Rh85UBr+IefBzA5UO WhTlr+MaxeCcTieKLrHH9Ng5i6VHBdLez9HYHPpfmdRUcAMZLtDSAxykK3u89doYew4l +7OK7rtrEA2ZhY9b+d7PYUYtF4wGZ9kes94odeBYrzkBsIXG5z/Ye+mYXdt55XKZ1kQN rOpQ== X-Gm-Message-State: AOAM533+xMxvV2Y+suaopLY2BvpgTiYeQVufarxK7E/Lc2Da4LN+bBi2 LLfoWB9ULkgm9IbEyQYoPYv2xQ== X-Google-Smtp-Source: ABdhPJxXqrSBs7UvzogxtH4gMcXG9+M+TmLs+sXRxykZ+DZpXvSgND5kRWDw2l55vrKZjOgmA443ew== X-Received: by 2002:a7b:c856:: with SMTP id c22mr1529367wml.5.1612437018821; Thu, 04 Feb 2021 03:10:18 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Rob Rice , linux-crypto@vger.kernel.org Subject: [PATCH 13/20] crypto: bcm: cipher: Provide description for 'req' and fix formatting issues Date: Thu, 4 Feb 2021 11:09:53 +0000 Message-Id: <20210204111000.2800436-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/cipher.c:1048: warning: Function parameter or member 'req' not described in 'spu_aead_rx_sg_create' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'cipher' not described in 'rfc4543_gcm_esp_setkey' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'key' not described in 'rfc4543_gcm_esp_setkey' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'keylen' not described in 'rfc4543_gcm_esp_setkey' Cc: Herbert Xu Cc: "David S. Miller" Cc: Rob Rice Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/cipher.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c index 851b149f71701..053315e260c22 100644 --- a/drivers/crypto/bcm/cipher.c +++ b/drivers/crypto/bcm/cipher.c @@ -1019,6 +1019,7 @@ static void handle_ahash_resp(struct iproc_reqctx_s *rctx) * a SPU response message for an AEAD request. Includes buffers to catch SPU * message headers and the response data. * @mssg: mailbox message containing the receive sg + * @req: Crypto API request * @rctx: crypto request context * @rx_frag_num: number of scatterlist elements required to hold the * SPU response message @@ -2952,9 +2953,9 @@ static int aead_gcm_esp_setkey(struct crypto_aead *cipher, /** * rfc4543_gcm_esp_setkey() - setkey operation for RFC4543 variant of GCM/GMAC. - * cipher: AEAD structure - * key: Key followed by 4 bytes of salt - * keylen: Length of key plus salt, in bytes + * @cipher: AEAD structure + * @key: Key followed by 4 bytes of salt + * @keylen: Length of key plus salt, in bytes * * Extracts salt from key and stores it to be prepended to IV on each request. * Digest is always 16 bytes