diff mbox series

[v6,2/3] dt-bindings: rng: bcm2835: document reset support

Message ID 20210305070132.2986-3-noltari@gmail.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series hwrng: bcm2835: add reset support | expand

Commit Message

Álvaro Fernández Rojas March 5, 2021, 7:01 a.m. UTC 
brcm,bcm6368-rng controllers require resetting the IPSEC clock in order to get
a functional RNG.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 v6: fix dt-bindings warnings.
 v5: no changes.
 v4: pass dt_binding_check.
 v3: make resets required if brcm,bcm6368-rng.
 v2: document reset support.

 .../devicetree/bindings/rng/brcm,bcm2835.yaml         | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Rob Herring March 8, 2021, 9:53 p.m. UTC | #1 
On Fri, 05 Mar 2021 08:01:31 +0100, Álvaro Fernández Rojas wrote:
> brcm,bcm6368-rng controllers require resetting the IPSEC clock in order to get
> a functional RNG.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  v6: fix dt-bindings warnings.
>  v5: no changes.
>  v4: pass dt_binding_check.
>  v3: make resets required if brcm,bcm6368-rng.
>  v2: document reset support.
> 
>  .../devicetree/bindings/rng/brcm,bcm2835.yaml         | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Florian Fainelli March 8, 2021, 10:02 p.m. UTC | #2 
On 3/4/21 11:01 PM, Álvaro Fernández Rojas wrote:
> brcm,bcm6368-rng controllers require resetting the IPSEC clock in order to get
> a functional RNG.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
index 5174492e22f3..6da674666d45 100644
--- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
+++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
@@ -28,6 +28,12 @@  properties:
   clock-names:
     const: ipsec
 
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: ipsec
+
   interrupts:
     maxItems: 1
 
@@ -44,6 +50,8 @@  then:
   required:
     - clocks
     - clock-names
+    - resets
+    - reset-names
 
 additionalProperties: false
 
@@ -68,4 +76,7 @@  examples:
 
         clocks = <&periph_clk 18>;
         clock-names = "ipsec";
+
+        resets = <&periph_rst 4>;
+        reset-names = "ipsec";
     };