From patchwork Thu Mar 18 12:44:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148123 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D55C43619 for ; Thu, 18 Mar 2021 12:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 075CE64F69 for ; Thu, 18 Mar 2021 12:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbhCRMpB (ORCPT ); Thu, 18 Mar 2021 08:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbhCRMoi (ORCPT ); Thu, 18 Mar 2021 08:44:38 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E1FDC06174A for ; Thu, 18 Mar 2021 05:44:38 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id g20so3459435wmk.3 for ; Thu, 18 Mar 2021 05:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fMTahAsaElMxqi8eZGk2JR1LgFKDb6Ye/mNpDFgFc8o=; b=dvpUi70deEjAO/2KnUGPQa0XxK3Y2FGyWvK8WilSPi5yM7x/GlW/mmywfd0OuvFXsO w6lhV+d8yzST2Zg9qCt55bDyrDOBVmv6AHYEOr8K5hdCWTHz8iJG7+mxg/p5ffvqiVfP x6Pm3TTB+MVoJLj/cI6sNyfjnzaBEWo3tSmdpO7rTketyLx1nolyDmibGPoJTmGHI6kG 7gvqDNcNKuCMvX9QvMZp972j+gpvWSjK8TEy5GaCdJk1S8Xi9rjFo1EqB8vQy10zPGtS UfgSE/gkIOUPiYE1Hi+pbdsENjj5b8vMpXZTGfTIw78mDjnOsXKTVMVp0eB7UbzJxJLM ABeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fMTahAsaElMxqi8eZGk2JR1LgFKDb6Ye/mNpDFgFc8o=; b=rS3vAyP3Cg6FB2OpAC3fjgY6qwyHpAM5yxIAF+9rb7xbhNaVh7ncziB2wYrQa0bcSG sN/c97rHsjuhkvae0DXV5r2PgBMFQSx484wc1liXbmAHWstF1/CceGzUAU/Kr/nq8+GC rE/UqEciuVysQPrn3K9I6JYXDeM1L5j6v9Yn891NXlYc3VJcJCB3mqLeXKv2zW8At9eQ VwB/GbeewpBWDuuW/FFzktKlw4du6ZRPkFApTTH7AgHrvViAytHV1n3rsMJiqqT9fl9+ BjCU/VZpaoHNZfN8PXm8P4fNz7OK3weHHiooPOILWxSyFMCShyknEwugyl8xjG0MU3WE dLMQ== X-Gm-Message-State: AOAM533xiQcKI3fUyglQoOUUpRgA8LcQ3oHR4pzVmZG6+ZgrlxV1oNrU +qvNIvkFn/U3+OONxcOPz58n/w== X-Google-Smtp-Source: ABdhPJzQx6Slpl2jsjhrwVq5uOSUJdpe2/Tb4K7eDbq/y5pEeET6/wucfCz6Y0rTCocip+3mo9Z6mg== X-Received: by 2002:a1c:bc56:: with SMTP id m83mr3548402wmf.174.1616071477165; Thu, 18 Mar 2021 05:44:37 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:36 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Horia_Geant=C4=83?= , Aymen Sghaier , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 07/10] crypto: caam: caampkc: Provide the name of the function and provide missing descriptions Date: Thu, 18 Mar 2021 12:44:19 +0000 Message-Id: <20210318124422.3200180-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx' drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx' Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Horia Geantă --- drivers/crypto/caam/caamalg_qi2.c | 3 +++ drivers/crypto/caam/caampkc.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c index a780e627838ae..8b8ed77d8715d 100644 --- a/drivers/crypto/caam/caamalg_qi2.c +++ b/drivers/crypto/caam/caamalg_qi2.c @@ -71,6 +71,9 @@ struct caam_skcipher_alg { * @adata: authentication algorithm details * @cdata: encryption algorithm details * @authsize: authentication tag (a.k.a. ICV / MAC) size + * @xts_key_fallback: true if fallback tfm needs to be used due + * to unsupported xts key lengths + * @fallback: xts fallback tfm */ struct caam_ctx { struct caam_flc flc[NUM_OP]; diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index dd5f101e43f83..e313233ec6de7 100644 --- a/drivers/crypto/caam/caampkc.c +++ b/drivers/crypto/caam/caampkc.c @@ -187,7 +187,8 @@ static void rsa_priv_f_done(struct device *dev, u32 *desc, u32 err, } /** - * Count leading zeros, need it to strip, from a given scatterlist + * caam_rsa_count_leading_zeros - Count leading zeros, need it to strip, + * from a given scatterlist * * @sgl : scatterlist to count zeros from * @nbytes: number of zeros, in bytes, to strip