diff mbox series

[-next] crypto: algboss - Replaced simple_strtol() with kstrtouint()

Message ID 20210524120834.1580343-1-liushixin2@huawei.com (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show
Series [-next] crypto: algboss - Replaced simple_strtol() with kstrtouint() | expand

Commit Message

Liu Shixin May 24, 2021, 12:08 p.m. UTC 
The simple_strtol() function is deprecated in some situation since
it does not check for the range overflow. Use kstrtouint() instead.

Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
 crypto/algboss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eric Biggers May 24, 2021, 9:57 p.m. UTC | #1 
On Mon, May 24, 2021 at 08:08:34PM +0800, Liu Shixin wrote:
> The simple_strtol() function is deprecated in some situation since
> it does not check for the range overflow. Use kstrtouint() instead.
> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
>  crypto/algboss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/crypto/algboss.c b/crypto/algboss.c
> index 5ebccbd6b74e..64bb8dab9584 100644
> --- a/crypto/algboss.c
> +++ b/crypto/algboss.c
> @@ -140,8 +140,8 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
>  			param->attrs[i].nu32.attr.rta_len =
>  				sizeof(param->attrs[i].nu32);
>  			param->attrs[i].nu32.attr.rta_type = CRYPTOA_U32;
> -			param->attrs[i].nu32.data.num =
> -				simple_strtol(name, NULL, 0);
> +			if (unlikely(kstrtouint(name, 0, &param->attrs[i].nu32.data.num)))
> +				goto err_free_param;

It would be better to just remove all the code related to CRYPTOA_U32 and
crypto_attr_u32, as it is never used.

- Eric
Herbert Xu June 3, 2021, 8:12 a.m. UTC | #2 
On Mon, May 24, 2021 at 02:57:50PM -0700, Eric Biggers wrote:
>
> It would be better to just remove all the code related to CRYPTOA_U32 and
> crypto_attr_u32, as it is never used.

I agree, it's been unused for over a decade.

Thanks,
Liu Shixin June 3, 2021, 10:53 a.m. UTC | #3 
On 2021/6/3 16:12, Herbert Xu wrote:
> On Mon, May 24, 2021 at 02:57:50PM -0700, Eric Biggers wrote:
>> It would be better to just remove all the code related to CRYPTOA_U32 and
>> crypto_attr_u32, as it is never used.
> I agree, it's been unused for over a decade.
>
> Thanks,

Thank you both for the advice, I will fix it.
Besides, I noticed that type CRYPTOA_UNSPEC has never been used, should I remove it together?

Thanks,
Herbert Xu June 3, 2021, 11:50 a.m. UTC | #4 
On Thu, Jun 03, 2021 at 06:53:00PM +0800, Liu Shixin wrote:
>
> Besides, I noticed that type CRYPTOA_UNSPEC has never been used, should I remove it together?

No please leave it alone.

Thanks,
diff mbox series

Patch

diff --git a/crypto/algboss.c b/crypto/algboss.c
index 5ebccbd6b74e..64bb8dab9584 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -140,8 +140,8 @@  static int cryptomgr_schedule_probe(struct crypto_larval *larval)
 			param->attrs[i].nu32.attr.rta_len =
 				sizeof(param->attrs[i].nu32);
 			param->attrs[i].nu32.attr.rta_type = CRYPTOA_U32;
-			param->attrs[i].nu32.data.num =
-				simple_strtol(name, NULL, 0);
+			if (unlikely(kstrtouint(name, 0, &param->attrs[i].nu32.data.num)))
+				goto err_free_param;
 		}
 
 		param->tb[i + 1] = &param->attrs[i].attr;