Message ID | 20210910064322.67705-7-hare@suse.de (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Herbert Xu |
Headers | show |
Series | nvme: In-band authentication support | expand |
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
On 9/9/21 11:43 PM, Hannes Reinecke wrote: > The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we > should be decoding this error, too. > > Signed-off-by: Hannes Reinecke <hare@suse.de> Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index 668c6bb7a567..9a8eade7cd23 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, dev_err(ctrl->device, "Connect command failed: host path error\n"); break; + case NVME_SC_AUTH_REQUIRED: + dev_err(ctrl->device, + "Connect command failed: authentication required\n"); + break; default: dev_err(ctrl->device, "Connect command failed, error wo/DNR bit: %d\n",
The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we should be decoding this error, too. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/nvme/host/fabrics.c | 4 ++++ 1 file changed, 4 insertions(+)