diff mbox series

crypto: api - Export crypto_boot_test_finished

Message ID 20210927112341.GA22483@gondor.apana.org.au (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series crypto: api - Export crypto_boot_test_finished | expand

Commit Message

Herbert Xu Sept. 27, 2021, 11:23 a.m. UTC 
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> [-- text/plain, encoding quoted-printable, charset: US-ASCII, 18 lines --]
> 
> Hi all,
> 
> After merging the crypto tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined!
> 
> Caused by commit
> 
>  adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
> 
> I have reverted that commit for today.

Oops, does this patch fix the problem?

---8<---
We need to export crypto_boot_test_finished in case api.c is
built-in while algapi.c is built as a module.

Fixes: adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Stephen Rothwell Sept. 28, 2021, 5:16 a.m. UTC | #1 
Hi Herbert,

On Mon, 27 Sep 2021 19:23:42 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Oops, does this patch fix the problem?

Yes, that fixes my build, thanks.

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # ppc32 build
Michael Ellerman Oct. 25, 2021, 6:28 a.m. UTC | #2 
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Herbert,
>
> On Mon, 27 Sep 2021 19:23:42 +0800 Herbert Xu <herbert@gondor.apana.org.au> wrote:
>>
>> Oops, does this patch fix the problem?
>
> Yes, that fixes my build, thanks.
>
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # ppc32 build

It fixes the build, but modules_install still fails:

  $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
  HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures

  $ git show e42dff467ee6 | patch -p1	# apply fixup patch
  patching file crypto/api.c

  $ make -s -j $(nproc) modules

  $ make -s modules_install
  depmod: ERROR: Cycle detected: crypto -> crypto_algapi -> crypto
  depmod: ERROR: Found 2 modules in dependency cycles!
  make: *** [Makefile:1801: modules_install] Error 1

cheers
Herbert Xu Oct. 26, 2021, 4:38 a.m. UTC | #3 
On Mon, Oct 25, 2021 at 05:28:24PM +1100, Michael Ellerman wrote:
>
> It fixes the build, but modules_install still fails:
> 
>   $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
>   HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures

Sorry, the fix is in the queue:

https://patchwork.kernel.org/project/linux-crypto/patch/20211019132802.GA14233@gondor.apana.org.au/

Cheers,
Michael Ellerman Oct. 29, 2021, 6:09 a.m. UTC | #4 
Herbert Xu <herbert@gondor.apana.org.au> writes:
> On Mon, Oct 25, 2021 at 05:28:24PM +1100, Michael Ellerman wrote:
>>
>> It fixes the build, but modules_install still fails:
>> 
>>   $ git checkout adad556efcdd42a1d9e060cbe5f6161cccf1fa28
>>   HEAD is now at adad556efcdd crypto: api - Fix built-in testing dependency failures
>
> Sorry, the fix is in the queue:
>
> https://patchwork.kernel.org/project/linux-crypto/patch/20211019132802.GA14233@gondor.apana.org.au/

Thanks, that fixes it for me.

cheers
diff mbox series

Patch

diff --git a/crypto/api.c b/crypto/api.c
index 1cf1f03347cc..ee5991fe11f8 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -32,6 +32,7 @@  BLOCKING_NOTIFIER_HEAD(crypto_chain);
 EXPORT_SYMBOL_GPL(crypto_chain);
 
 DEFINE_STATIC_KEY_FALSE(crypto_boot_test_finished);
+EXPORT_SYMBOL_GPL(crypto_boot_test_finished);
 
 static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg);