| Message ID | 20211013105541.68045-18-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | Enable Qualcomm Crypto Engine on sm8250 | expand |
Hi Bhupesh, On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > Print a failure message (dev_err) in case the qcom qce crypto > driver probe() fails. > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > drivers/crypto/qce/core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 576c416461f9..cb8c77709e1e 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -281,6 +281,8 @@ static int qce_crypto_probe(struct platform_device *pdev) > icc_set_bw(qce->mem_path, 0, 0); > err_mem_path_put: > icc_put(qce->mem_path); > + > + dev_err(dev, "%s failed : %d\n", __func__, ret); > return ret; > } > As for me the rationale of this change is quite non-obvious, a user is well informed, if a driver probe fails. I would rather ask you to consider to drop this change. -- Best wishes, Vladimir
Hi Vladimir, On Thu, 14 Oct 2021 at 00:56, Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> wrote: > > Hi Bhupesh, > > On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > > Print a failure message (dev_err) in case the qcom qce crypto > > driver probe() fails. > > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > drivers/crypto/qce/core.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > > index 576c416461f9..cb8c77709e1e 100644 > > --- a/drivers/crypto/qce/core.c > > +++ b/drivers/crypto/qce/core.c > > @@ -281,6 +281,8 @@ static int qce_crypto_probe(struct platform_device *pdev) > > icc_set_bw(qce->mem_path, 0, 0); > > err_mem_path_put: > > icc_put(qce->mem_path); > > + > > + dev_err(dev, "%s failed : %d\n", __func__, ret); > > return ret; > > } > > > > As for me the rationale of this change is quite non-obvious, a user is well > informed, if a driver probe fails. I would rather ask you to consider to > drop this change. Normally, when a driver probe fails, the kernel logging system does pretty well to hold logs for the same and these can be referred to later for debugging. However with crypto tests on arm machines, since the arm crypto interfaces are also normally enabled by default, so boot-on crypto tests (enabled via CRYPTO_MANAGER_EXTRA_TESTS), which normally take place at algorithm registration, it's sometimes difficult to check the qce driver probe errors / failures, in case the board hangs or reboots while running the boot-on crypto tests. In such a case, if qce crypto driver probe fails, it is useful to see a failure message on the serial console itself. Regards, Bhupesh
diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c index 576c416461f9..cb8c77709e1e 100644 --- a/drivers/crypto/qce/core.c +++ b/drivers/crypto/qce/core.c @@ -281,6 +281,8 @@ static int qce_crypto_probe(struct platform_device *pdev) icc_set_bw(qce->mem_path, 0, 0); err_mem_path_put: icc_put(qce->mem_path); + + dev_err(dev, "%s failed : %d\n", __func__, ret); return ret; }