| Message ID | 20211020100348.42896-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: s5p-sss - Add error handling in s5p_aes_probe() | expand |
On 20/10/2021 12:03, Tang Bin wrote: > The function s5p_aes_probe() does not perform sufficient error > checking after executing platform_get_resource(), thus fix it. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/crypto/s5p-sss.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index 55aa3a711..7717e9e59 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev) > > variant = find_s5p_sss_version(pdev); > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EINVAL; > > /* > * Note: HASH and PRNG uses the same registers in secss, avoid > You need fixes and cc-stable: Fixes: c2afad6c6105 ("crypto: s5p-sss - Add HASH support for Exynos") Cc: <stable@vger.kernel.org> With above added: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index 55aa3a711..7717e9e59 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -2171,6 +2171,8 @@ static int s5p_aes_probe(struct platform_device *pdev) variant = find_s5p_sss_version(pdev); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; /* * Note: HASH and PRNG uses the same registers in secss, avoid
The function s5p_aes_probe() does not perform sufficient error checking after executing platform_get_resource(), thus fix it. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/crypto/s5p-sss.c | 2 ++ 1 file changed, 2 insertions(+)