From patchwork Mon Nov 22 07:47:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 12631361 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA440C43217 for ; Mon, 22 Nov 2021 07:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234005AbhKVHu5 (ORCPT ); Mon, 22 Nov 2021 02:50:57 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:57148 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230142AbhKVHut (ORCPT ); Mon, 22 Nov 2021 02:50:49 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 3AC6C1FD56; Mon, 22 Nov 2021 07:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1637567261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WrgCh25NwnVfz4gld5vXX6xGM5yqU1dka6lj5KLnPE4=; b=BPF75jPWu7rvmd+AJ8jxUW1gBklMh/cqJzZFIYjWtvnUjS/q3YXIOA3zBu+1zA48einPkV yVkV9SJmRnyxQ1juomo9vkbcpZlV4hOu/8PznEdnHxsWTJBe7IxryzwYfrC6NAXMZczLdX fLcW53VnLOHfgsDYfiDwXfJHWlUr9vY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1637567261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WrgCh25NwnVfz4gld5vXX6xGM5yqU1dka6lj5KLnPE4=; b=TtibRwbmZMqDyy+5qpGWRdr4p0iLtasTJvcH9ajFKX5UlQgwcxVyevKnBFpYMbKrfqpGmP 9JEVLbxXA6swCNBQ== Received: from adalid.arch.suse.de (adalid.arch.suse.de [10.161.8.13]) by relay2.suse.de (Postfix) with ESMTP id 13634A3B8B; Mon, 22 Nov 2021 07:47:41 +0000 (UTC) Received: by adalid.arch.suse.de (Postfix, from userid 16045) id 376C551917DE; Mon, 22 Nov 2021 08:47:40 +0100 (CET) From: Hannes Reinecke To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , linux-nvme@lists.infradead.org, Herbert Xu , David Miller , linux-crypto@vger.kernel.org, Hannes Reinecke , Chaitanya Kulkarni , Himanshu Madhani Subject: [PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error Date: Mon, 22 Nov 2021 08:47:21 +0100 Message-Id: <20211122074727.25988-7-hare@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20211122074727.25988-1-hare@suse.de> References: <20211122074727.25988-1-hare@suse.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we should be decoding this error, too. Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Reviewed-by: Himanshu Madhani --- drivers/nvme/host/fabrics.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index c5a2b71c5268..a1343a0790f6 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, dev_err(ctrl->device, "Connect command failed: host path error\n"); break; + case NVME_SC_AUTH_REQUIRED: + dev_err(ctrl->device, + "Connect command failed: authentication required\n"); + break; default: dev_err(ctrl->device, "Connect command failed, error wo/DNR bit: %d\n",