From patchwork Thu Jan 13 23:54:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Biggers X-Patchwork-Id: 12713212 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7705C433F5 for ; Thu, 13 Jan 2022 23:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238287AbiAMX4d (ORCPT ); Thu, 13 Jan 2022 18:56:33 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:50064 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235807AbiAMX4c (ORCPT ); Thu, 13 Jan 2022 18:56:32 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 22BD861D0D; Thu, 13 Jan 2022 23:56:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DF96C36AF2; Thu, 13 Jan 2022 23:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642118191; bh=oKepsBiUvipoUsRwWzzacVjvRjKomlWW+JhTo6LpOqw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ir6qVvGMqy8tGaEwNG8lRfmidg8fOgoDFJv1HZ9COA+XCdjul4h5hupLpTZWqhhsY stlBZA0WEnB10iWf18x2J1Sp/Eh4GkBrl4dcd7GRpk+fuXU+d/aByYP8KaeKyCKW8D UNjwI8bT4v7ieWiXdq8sNZtD0z9VsKdDZppX6GY0YmFB79npAgheHhPck/ndau7KFy GoTbwultgCUAs9wlEK1r8/YVd1LIq6N0KsESPRU9PBecR5sJZbi/GZFEtlvATzs7XJ /P/5XHEZa+w4+LFAjNaZIfwXg+ZgPO67irBpW281MHDhbMOGhvQVZXJVcbP3TpmKvb np6Z2rIQeJdPw== From: Eric Biggers To: keyrings@vger.kernel.org, David Howells , Jarkko Sakkinen Cc: Denis Kenzior , Marcel Holtmann , James Morris , linux-crypto@vger.kernel.org Subject: [PATCH 2/3] KEYS: asym_tpm: fix incorrect comment Date: Thu, 13 Jan 2022 15:54:39 -0800 Message-Id: <20220113235440.90439-3-ebiggers@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220113235440.90439-1-ebiggers@kernel.org> References: <20220113235440.90439-1-ebiggers@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Eric Biggers tpm_key_create() doesn't actually load the key into the TPM. Fix the comment to describe what the function does. Signed-off-by: Eric Biggers Acked-by: Jarkko Sakkinen --- crypto/asymmetric_keys/asym_tpm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/crypto/asymmetric_keys/asym_tpm.c b/crypto/asymmetric_keys/asym_tpm.c index 60d20d44c885..2e365a221fbe 100644 --- a/crypto/asymmetric_keys/asym_tpm.c +++ b/crypto/asymmetric_keys/asym_tpm.c @@ -900,7 +900,11 @@ static int extract_key_parameters(struct tpm_key *tk) return 0; } -/* Given the blob, parse it and load it into the TPM */ +/* + * Verify that a supported TPM is present, then parse the key blob. We don't + * actually load the key into the TPM here; that happens only for the actual + * sign and decrypt operations. + */ struct tpm_key *tpm_key_create(const void *blob, uint32_t blob_len) { int r;