diff mbox series

[v2,1/2] crypto: sa2ul - Set the supported_algos bits individually

Message ID 20220706191144.26437-1-afd@ti.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series [v2,1/2] crypto: sa2ul - Set the supported_algos bits individually | expand

Commit Message

Andrew Davis July 6, 2022, 7:11 p.m. UTC
Setting these individually gives a better picture of supported
functions at a glance. Plus if the list changes an unwanted
one will not accidentally get set with GENMASK.

Signed-off-by: Andrew Davis <afd@ti.com>
---

Changes from v1:
 - Split these two patches from the DTS changes

 drivers/crypto/sa2ul.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Herbert Xu July 15, 2022, 8:48 a.m. UTC | #1
On Wed, Jul 06, 2022 at 02:11:43PM -0500, Andrew Davis wrote:
> Setting these individually gives a better picture of supported
> functions at a glance. Plus if the list changes an unwanted
> one will not accidentally get set with GENMASK.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> 
> Changes from v1:
>  - Split these two patches from the DTS changes
> 
>  drivers/crypto/sa2ul.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

All applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index 6957a125b4470..1d732113b81ec 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -2361,7 +2361,15 @@  static int sa_link_child(struct device *dev, void *data)
 static struct sa_match_data am654_match_data = {
 	.priv = 1,
 	.priv_id = 1,
-	.supported_algos = GENMASK(SA_ALG_AUTHENC_SHA256_AES, 0),
+	.supported_algos = BIT(SA_ALG_CBC_AES) |
+			   BIT(SA_ALG_EBC_AES) |
+			   BIT(SA_ALG_CBC_DES3) |
+			   BIT(SA_ALG_ECB_DES3) |
+			   BIT(SA_ALG_SHA1) |
+			   BIT(SA_ALG_SHA256) |
+			   BIT(SA_ALG_SHA512) |
+			   BIT(SA_ALG_AUTHENC_SHA1_AES) |
+			   BIT(SA_ALG_AUTHENC_SHA256_AES),
 };
 
 static struct sa_match_data am64_match_data = {