diff mbox series

[RESEND,3/8] hwrng: bcm2835: bcmbca: Replace ARCH_BCM_63XX with ARCH_BCMBCA

Message ID 20220707065800.261269-3-william.zhang@broadcom.com (mailing list archive)
State Not Applicable
Delegated to: Herbert Xu
Headers show
Series None | expand

Commit Message

William Zhang July 7, 2022, 6:57 a.m. UTC
Prepare for the BCM63138 ARCH_BCM_63XX migration to ARCH_BCMBCA. Make
HW_RANDOM_BCM2835 depending on ARCH_BCMBCA.

Signed-off-by: William Zhang <william.zhang@broadcom.com>
---

 drivers/char/hw_random/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli July 7, 2022, 4:23 p.m. UTC | #1
On 7/6/22 23:57, William Zhang wrote:
> Prepare for the BCM63138 ARCH_BCM_63XX migration to ARCH_BCMBCA. Make
> HW_RANDOM_BCM2835 depending on ARCH_BCMBCA.
> 
> Signed-off-by: William Zhang <william.zhang@broadcom.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

There is no cover letter for this 8 patch series :/ it is not clear to 
me whether each subsystem maintainer will be in a posotion to merge 
these patches individually, yet still have all 8 (7 of them actually, 
see comment to patch 1) land in 5.20.

Alternatively, we can merge these patches through the Broadcom ARM SoC 
pull request(s) to ensure they all land at the same time.
William Zhang July 7, 2022, 5:05 p.m. UTC | #2
On 7/7/22 09:23, Florian Fainelli wrote:
> On 7/6/22 23:57, William Zhang wrote:
>> Prepare for the BCM63138 ARCH_BCM_63XX migration to ARCH_BCMBCA. Make
>> HW_RANDOM_BCM2835 depending on ARCH_BCMBCA.
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> 
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> There is no cover letter for this 8 patch series :/ it is not clear to 
> me whether each subsystem maintainer will be in a posotion to merge 
> these patches individually, yet still have all 8 (7 of them actually, 
> see comment to patch 1) land in 5.20.
> 
The cover letter will gather all the recipients which will be more than 
50 and this mailing list blocks such post until it is manually reviewed 
and approved.  But looks this list is not actively moderated and my 
cover letter and the combined patch of this set in v1 still have not 
been approved yet...

> Alternatively, we can merge these patches through the Broadcom ARM SoC 
> pull request(s) to ensure they all land at the same time.

Thank you Florian!  I agree and the changes in this patch series are 
trivial and only for Broadcom ARM Broadband chip after all.
Conor Dooley July 7, 2022, 5:16 p.m. UTC | #3
On 07/07/2022 18:05, William Zhang wrote:
> On 7/7/22 09:23, Florian Fainelli wrote:
>> On 7/6/22 23:57, William Zhang wrote:
>>> Prepare for the BCM63138 ARCH_BCM_63XX migration to ARCH_BCMBCA. Make
>>> HW_RANDOM_BCM2835 depending on ARCH_BCMBCA.
>>>
>>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>
>> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>> There is no cover letter for this 8 patch series :/ it is not clear to me whether each subsystem maintainer will be in a posotion to merge these patches individually, yet still have all 8 (7 of them actually, see comment to patch 1) land in 5.20.
>>
> The cover letter will gather all the recipients which will be more than 50

tbf, you probably could cut down the CC list if you want, it isnt required
to CC absolutely everyone that gets spat out by get_maintainer.

For example, I am CCed because I was a recent author for the hwrng kconfig
file, so people like me could be safely excluded if you need to cut down on
the number of people that you are CCing.

Not that I have a problem with being CCed, just if it helps you hit a min.
threshold feel free to drop me :)
William Zhang July 7, 2022, 6:18 p.m. UTC | #4
On 7/7/22 10:16, Conor.Dooley@microchip.com wrote:
> On 07/07/2022 18:05, William Zhang wrote:
>> On 7/7/22 09:23, Florian Fainelli wrote:
>>> On 7/6/22 23:57, William Zhang wrote:
>>>> Prepare for the BCM63138 ARCH_BCM_63XX migration to ARCH_BCMBCA. Make
>>>> HW_RANDOM_BCM2835 depending on ARCH_BCMBCA.
>>>>
>>>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>>
>>> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>>>
>>> There is no cover letter for this 8 patch series :/ it is not clear to me whether each subsystem maintainer will be in a posotion to merge these patches individually, yet still have all 8 (7 of them actually, see comment to patch 1) land in 5.20.
>>>
>> The cover letter will gather all the recipients which will be more than 50
> 
> tbf, you probably could cut down the CC list if you want, it isnt required
> to CC absolutely everyone that gets spat out by get_maintainer.
> 
> For example, I am CCed because I was a recent author for the hwrng kconfig
> file, so people like me could be safely excluded if you need to cut down on
> the number of people that you are CCing.
> 
> Not that I have a problem with being CCed, just if it helps you hit a min.
> threshold feel free to drop me :)
Thanks! That is my plan too. Try to figure out the threshold now lol
Florian Fainelli July 8, 2022, 3:49 a.m. UTC | #5
On 7/7/2022 11:18 AM, William Zhang wrote:
> 
> 
> On 7/7/22 10:16, Conor.Dooley@microchip.com wrote:
>> On 07/07/2022 18:05, William Zhang wrote:
>>> On 7/7/22 09:23, Florian Fainelli wrote:
>>>> On 7/6/22 23:57, William Zhang wrote:
>>>>> Prepare for the BCM63138 ARCH_BCM_63XX migration to ARCH_BCMBCA. Make
>>>>> HW_RANDOM_BCM2835 depending on ARCH_BCMBCA.
>>>>>
>>>>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>>>
>>>> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>>>>
>>>> There is no cover letter for this 8 patch series :/ it is not clear 
>>>> to me whether each subsystem maintainer will be in a posotion to 
>>>> merge these patches individually, yet still have all 8 (7 of them 
>>>> actually, see comment to patch 1) land in 5.20.
>>>>
>>> The cover letter will gather all the recipients which will be more 
>>> than 50
>>
>> tbf, you probably could cut down the CC list if you want, it isnt 
>> required
>> to CC absolutely everyone that gets spat out by get_maintainer.
>>
>> For example, I am CCed because I was a recent author for the hwrng 
>> kconfig
>> file, so people like me could be safely excluded if you need to cut 
>> down on
>> the number of people that you are CCing.
>>
>> Not that I have a problem with being CCed, just if it helps you hit a 
>> min.
>> threshold feel free to drop me :)
> Thanks! That is my plan too. Try to figure out the threshold now lol

Try adding --norolestats to your get_maintainer.pl invocation.
Florian Fainelli July 11, 2022, 2:11 a.m. UTC | #6
On Wed,  6 Jul 2022 23:57:54 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Prepare for the BCM63138 ARCH_BCM_63XX migration to ARCH_BCMBCA. Make
> HW_RANDOM_BCM2835 depending on ARCH_BCMBCA.
> 
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian
diff mbox series

Patch

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index b3f2d55dc551..3da8e85f8aae 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -87,7 +87,7 @@  config HW_RANDOM_BA431
 config HW_RANDOM_BCM2835
 	tristate "Broadcom BCM2835/BCM63xx Random Number Generator support"
 	depends on ARCH_BCM2835 || ARCH_BCM_NSP || ARCH_BCM_5301X || \
-		   ARCH_BCM_63XX || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
+		   ARCH_BCMBCA || BCM63XX || BMIPS_GENERIC || COMPILE_TEST
 	default HW_RANDOM
 	help
 	  This driver provides kernel-side support for the Random Number