| Message ID | 20220802074820.1648786-1-ye.xingchen@zte.com.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [linux-next] crypto: sun8i-ce:using the pm_runtime_resume_and_get to simplify the code | expand |
Dne torek, 02. avgust 2022 ob 09:48:20 CEST je cgel.zte@gmail.com napisal(a): > From: ye xingchen <ye.xingchen@zte.com.cn> > > Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync > and pm_runtime_put_noidle. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c > b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c index > 19cd2e52f89d..ef9cfc61af32 100644 > --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c > +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c > @@ -54,9 +54,8 @@ static int sun8i_ce_trng_read(struct hwrng *rng, void > *data, size_t max, bool wa goto err_dst; > } > > - err = pm_runtime_get_sync(ce->dev); > + err = pm_runtime_resume_and_get(ce->dev); > if (err < 0) { > - pm_runtime_put_noidle(ce->dev); > goto err_pm; > } You should also remove braces, since there is only one line left. With that fixed: Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej
cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Using pm_runtime_resume_and_get() to instade of pm_runtime_get_sync > and pm_runtime_put_noidle. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c index 19cd2e52f89d..ef9cfc61af32 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c @@ -54,9 +54,8 @@ static int sun8i_ce_trng_read(struct hwrng *rng, void *data, size_t max, bool wa goto err_dst; } - err = pm_runtime_get_sync(ce->dev); + err = pm_runtime_resume_and_get(ce->dev); if (err < 0) { - pm_runtime_put_noidle(ce->dev); goto err_pm; }