crypto/drbg.c:remove unnecessary (void*) conversions

Commit Message

Dong Chuanjian Aug. 9, 2022, 9:14 a.m. UTC

remove unnecessary void* type casting

Signed-off-by: Dong Chuanjian <[e-mail]>

Comments

Eric Biggers Aug. 9, 2022, 6:07 p.m. UTC | #1

On Tue, Aug 09, 2022 at 05:14:52PM +0800, Dong Chuanjian wrote:
>  	struct crypto_cipher *tfm =
> -		(struct crypto_cipher *)drbg->priv_data;
> +		drbg->priv_data;

Might as well join this into one line.

>  
>  	crypto_cipher_setkey(tfm, key, (drbg_keylen(drbg)));
>  }
> @@ -1828,7 +1828,7 @@ static int drbg_kcapi_sym(struct drbg_state *drbg, unsigned char *outval,
>  			  const struct drbg_string *in)
>  {
>  	struct crypto_cipher *tfm =
> -		(struct crypto_cipher *)drbg->priv_data;
> +		drbg->priv_data;

Likewise.

- Eric

Dong Chuanjian Aug. 11, 2022, 7:17 a.m. UTC | #2

v2:
Turn assignments less than 75 characters into one line

Patch

diff --git a/crypto/drbg.c b/crypto/drbg.c
index 177983b6ae38..f41ec3088ecc 100644
--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -1703,7 +1703,7 @@  static int drbg_init_hash_kernel(struct drbg_state *drbg)
 
 static int drbg_fini_hash_kernel(struct drbg_state *drbg)
 {
-	struct sdesc *sdesc = (struct sdesc *)drbg->priv_data;
+	struct sdesc *sdesc = drbg->priv_data;
 	if (sdesc) {
 		crypto_free_shash(sdesc->shash.tfm);
 		kfree_sensitive(sdesc);
@@ -1715,7 +1715,7 @@  static int drbg_fini_hash_kernel(struct drbg_state *drbg)
 static void drbg_kcapi_hmacsetkey(struct drbg_state *drbg,
 				  const unsigned char *key)
 {
-	struct sdesc *sdesc = (struct sdesc *)drbg->priv_data;
+	struct sdesc *sdesc = drbg->priv_data;
 
 	crypto_shash_setkey(sdesc->shash.tfm, key, drbg_statelen(drbg));
 }
@@ -1723,7 +1723,7 @@  static void drbg_kcapi_hmacsetkey(struct drbg_state *drbg,
 static int drbg_kcapi_hash(struct drbg_state *drbg, unsigned char *outval,
 			   const struct list_head *in)
 {
-	struct sdesc *sdesc = (struct sdesc *)drbg->priv_data;
+	struct sdesc *sdesc = drbg->priv_data;
 	struct drbg_string *input = NULL;
 
 	crypto_shash_init(&sdesc->shash);
@@ -1819,7 +1819,7 @@  static void drbg_kcapi_symsetkey(struct drbg_state *drbg,
 				 const unsigned char *key)
 {
 	struct crypto_cipher *tfm =
-		(struct crypto_cipher *)drbg->priv_data;
+		drbg->priv_data;
 
 	crypto_cipher_setkey(tfm, key, (drbg_keylen(drbg)));
 }
@@ -1828,7 +1828,7 @@  static int drbg_kcapi_sym(struct drbg_state *drbg, unsigned char *outval,
 			  const struct drbg_string *in)
 {
 	struct crypto_cipher *tfm =
-		(struct crypto_cipher *)drbg->priv_data;
+		drbg->priv_data;
 
 	/* there is only component in *in */
 	BUG_ON(in->len < drbg_blocklen(drbg));