| Message ID | 20220922142216.17581-2-tmaimon77@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | rng: npcm: add Arbel NPCM8XX support | expand |
On 22/09/2022 16:22, Tomer Maimon wrote: > Add a compatible string for Nuvoton BMC NPCM845 RNG. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml | 4 +++- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, 22 Sep 2022 17:22:15 +0300, Tomer Maimon wrote: > Add a compatible string for Nuvoton BMC NPCM845 RNG. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml:20:9: [warning] wrong indentation: expected 6 but found 8 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1681163 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 22/09/2022 17:08, Krzysztof Kozlowski wrote: > On 22/09/2022 16:22, Tomer Maimon wrote: >> Add a compatible string for Nuvoton BMC NPCM845 RNG. >> >> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> >> --- >> Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml | 4 +++- > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> And un-acked. Test your patches. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml index abd134c9d400..e0071faa00f0 100644 --- a/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml +++ b/Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml @@ -16,7 +16,9 @@ maintainers: properties: compatible: - const: nuvoton,npcm750-rng + enum: + - nuvoton,npcm750-rng + - nuvoton,npcm845-rng reg: maxItems: 1
Add a compatible string for Nuvoton BMC NPCM845 RNG. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- Documentation/devicetree/bindings/rng/nuvoton,npcm-rng.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)