diff mbox series

[2/4] dt-bindings: qcom-qce: document clocks and clock-names as optional

Message ID 20221114-narmstrong-sm8550-upstream-qce-v1-2-31b489d5690a@linaro.org (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show
Series crypto: qcom-qce: add support for SM8550 | expand

Commit Message

Neil Armstrong Nov. 16, 2022, 10:23 a.m. UTC
On certain Snapdragon processors, the crypto engine clocks are enabled by
default by security firmware.

Drop clocks and clock-names from the required properties list.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 2 --
 1 file changed, 2 deletions(-)

Comments

Krzysztof Kozlowski Nov. 16, 2022, 11:52 a.m. UTC | #1
On 16/11/2022 11:23, Neil Armstrong wrote:
> On certain Snapdragon processors, the crypto engine clocks are enabled by

If by "enabled" you mean "controlled", then looks fine. Otherwise
without exclusive control by firmware, clock enabled e.g. by firmware or
bootloader might still be disabled by SoC. Which case is here?

Probably we should have dedicated compatibles for that.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index aa2f676f5382..f25089bf9a2b 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -67,8 +67,6 @@  properties:
 required:
   - compatible
   - reg
-  - clocks
-  - clock-names
   - dmas
   - dma-names