diff mbox series

[v2,6/6] crypto: testmgr - allow ecdsa-nist-p256 and -p384 in FIPS mode

Message ID 20221229203708.13628-7-vdronov@redhat.com (mailing list archive)
State Superseded
Delegated to: Herbert Xu
Headers show
Series Trivial set of FIPS 140-3 related changes | expand

Commit Message

Vladis Dronov Dec. 29, 2022, 8:37 p.m. UTC 
From: Nicolai Stange <nstange@suse.de>

The kernel provides implementations of the NIST ECDSA signature
verification primitives. For key sizes of 256 and 384 bits respectively
they are approved and can be enabled in FIPS mode. Do so.

Signed-off-by: Nicolai Stange <nstange@suse.de>
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Reviewed-by: Eric Biggers <ebiggers@google.com>
---
 crypto/testmgr.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Eric Biggers Dec. 29, 2022, 9:01 p.m. UTC | #1 
On Thu, Dec 29, 2022 at 09:37:08PM +0100, Vladis Dronov wrote:
> From: Nicolai Stange <nstange@suse.de>
> 
> The kernel provides implementations of the NIST ECDSA signature
> verification primitives. For key sizes of 256 and 384 bits respectively
> they are approved and can be enabled in FIPS mode. Do so.
> 
> Signed-off-by: Nicolai Stange <nstange@suse.de>
> Signed-off-by: Vladis Dronov <vdronov@redhat.com>
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Please don't add my Reviewed-by to patches I didn't review.  I only gave
Reviewed-by on "[PATCH 2/6] crypto: xts - drop xts_check_key()".  I didn't look
at the other patches in the series much, as I'm not very interested in them.

- Eric
Vladis Dronov Dec. 29, 2022, 9:15 p.m. UTC | #2 
On Thu, Dec 29, 2022 at 10:02 PM Eric Biggers <ebiggers@kernel.org> wrote:
> ... skip ...
> Please don't add my Reviewed-by to patches I didn't review.  I only gave
> Reviewed-by on "[PATCH 2/6] crypto: xts - drop xts_check_key()".  I didn't look
> at the other patches in the series much, as I'm not very interested in them.
>
> - Eric

My bad. I'm sorry for misunderstanding and this traffic and mess. Let me send v3
with your review tag for the patch 2/6 only.

Best regards,
Vladis
diff mbox series

Patch

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index a223cf5f3626..795c4858c741 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -5034,12 +5034,14 @@  static const struct alg_test_desc alg_test_descs[] = {
 	}, {
 		.alg = "ecdsa-nist-p256",
 		.test = alg_test_akcipher,
+		.fips_allowed = 1,
 		.suite = {
 			.akcipher = __VECS(ecdsa_nist_p256_tv_template)
 		}
 	}, {
 		.alg = "ecdsa-nist-p384",
 		.test = alg_test_akcipher,
+		.fips_allowed = 1,
 		.suite = {
 			.akcipher = __VECS(ecdsa_nist_p384_tv_template)
 		}