diff mbox series

[6/9] dt-bindings: crypto: fsl-sec4-snvs: add fsl sec 5.x compatible

Message ID 20230301015702.3388458-7-peng.fan@oss.nxp.com (mailing list archive)
State Not Applicable
Delegated to: Herbert Xu
Headers show
Series dt-bindings: crypto: convert fsl-sec4 to DT schema | expand

Commit Message

Peng Fan (OSS) March 1, 2023, 1:56 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Add fsl sec 5.x compatible, which is used by layerscape SoCs.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski March 3, 2023, 10:01 a.m. UTC | #1 
On 01/03/2023 02:56, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add fsl sec 5.x compatible, which is used by layerscape SoCs.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> index 6878ae8127ec..1a4b4975e1d9 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> @@ -24,6 +24,10 @@ maintainers:
>  properties:
>    compatible:
>      oneOf:
> +      - items:
> +          - const: fsl,sec-v5.4-mon
> +          - const: fsl,sec-v5.0-mon
> +          - const: fsl,sec-v4.0-mon

This is odd... all of these are the same version then? What's the point
of having versionable compatibles if they are compatible?

Best regards,
Krzysztof
Gaurav Jain March 7, 2023, 6:47 a.m. UTC | #2 
> -----Original Message-----
> From: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> Sent: Wednesday, March 1, 2023 7:27 AM
> To: herbert@gondor.apana.org.au; davem@davemloft.net;
> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; Horia Geanta
> <horia.geanta@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>; Gaurav Jain
> <gaurav.jain@nxp.com>; shawnguo@kernel.org; s.hauer@pengutronix.de
> Cc: kernel@pengutronix.de; stefan@agner.ch; linux-crypto@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; Peng Fan <peng.fan@nxp.com>
> Subject: [PATCH 6/9] dt-bindings: crypto: fsl-sec4-snvs: add fsl sec 5.x
> compatible
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add fsl sec 5.x compatible, which is used by layerscape SoCs.
I can see sec-v5.2-mon, sec-v5.3-mon for Qoriq.

Regards
Gaurav
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> index 6878ae8127ec..1a4b4975e1d9 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> @@ -24,6 +24,10 @@ maintainers:
>  properties:
>    compatible:
>      oneOf:
> +      - items:
> +          - const: fsl,sec-v5.4-mon
> +          - const: fsl,sec-v5.0-mon
> +          - const: fsl,sec-v4.0-mon
>        - items:
>            - const: fsl,sec-v4.0-mon
>            - const: syscon
> --
> 2.37.1
Peng Fan March 7, 2023, 6:58 a.m. UTC | #3 
> Subject: RE: [PATCH 6/9] dt-bindings: crypto: fsl-sec4-snvs: add fsl sec 5.x
> compatible
> 
> 
> 
> > -----Original Message-----
> > From: Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > Sent: Wednesday, March 1, 2023 7:27 AM
> > To: herbert@gondor.apana.org.au; davem@davemloft.net;
> > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; Horia Geanta
> > <horia.geanta@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>;
> Gaurav
> > Jain <gaurav.jain@nxp.com>; shawnguo@kernel.org;
> > s.hauer@pengutronix.de
> > Cc: kernel@pengutronix.de; stefan@agner.ch;
> > linux-crypto@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; linux-arm- kernel@lists.infradead.org;
> > Peng Fan <peng.fan@nxp.com>
> > Subject: [PATCH 6/9] dt-bindings: crypto: fsl-sec4-snvs: add fsl sec
> > 5.x compatible
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add fsl sec 5.x compatible, which is used by layerscape SoCs.
> I can see sec-v5.2-mon, sec-v5.3-mon for Qoriq.

Please go with Rob's patch which is earlier than my patchset.

https://lore.kernel.org/lkml/d4c76900-1985-428b-4050-26fd4a0daaf8@oss.nxp.com/T/

Thanks,
Peng.

> 
> Regards
> Gaurav
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> > b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> > index 6878ae8127ec..1a4b4975e1d9 100644
> > --- a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
> > @@ -24,6 +24,10 @@ maintainers:
> >  properties:
> >    compatible:
> >      oneOf:
> > +      - items:
> > +          - const: fsl,sec-v5.4-mon
> > +          - const: fsl,sec-v5.0-mon
> > +          - const: fsl,sec-v4.0-mon
> >        - items:
> >            - const: fsl,sec-v4.0-mon
> >            - const: syscon
> > --
> > 2.37.1
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
index 6878ae8127ec..1a4b4975e1d9 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-sec4-snvs.yaml
@@ -24,6 +24,10 @@  maintainers:
 properties:
   compatible:
     oneOf:
+      - items:
+          - const: fsl,sec-v5.4-mon
+          - const: fsl,sec-v5.0-mon
+          - const: fsl,sec-v4.0-mon
       - items:
           - const: fsl,sec-v4.0-mon
           - const: syscon