diff mbox series

[3/6] dt-bindings: imxgpt: add imx6ul compatible

Message ID 20230305225901.7119-4-stefan.wahren@i2se.com (mailing list archive)
State Not Applicable
Delegated to: Herbert Xu
Headers show
Series ARM: dts: imx6ull: Fix dtbs_check warnings | expand

Commit Message

Stefan Wahren March 5, 2023, 10:58 p.m. UTC
Currently the dtbs_check for imx6ul generates warnings like this:

['fsl,imx6ul-gpt', 'fsl,imx6sx-gpt'] is too long

Since the imx6ul GPT IP is compatible to imx6dl, add the compatible
to the enum. The mentioned warning also needs adjustment of the
affected DTS, but this should be done in a different patch.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski March 6, 2023, 6:39 a.m. UTC | #1
On 05/03/2023 23:58, Stefan Wahren wrote:
> Currently the dtbs_check for imx6ul generates warnings like this:
> 
> ['fsl,imx6ul-gpt', 'fsl,imx6sx-gpt'] is too long
> 
> Since the imx6ul GPT IP is compatible to imx6dl, add the compatible
> to the enum. The mentioned warning also needs adjustment of the
> affected DTS, but this should be done in a different patch.
> 

Unfortunately I do not understand it. Your next commit says - according
to DT schema - while the bindings do not suggest any compatibility here
for imx6ul. It seems you make a change and then justify with it another
change (next commit). Instead please justify both commits - this and
next - with proper real explanation, what is compatible with what.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
index 716c6afcca1f..8d9e8c1b7dcf 100644
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
@@ -31,6 +31,7 @@  properties:
           - enum:
               - fsl,imx6sl-gpt
               - fsl,imx6sx-gpt
+              - fsl,imx6ul-gpt
               - fsl,imxrt1050-gpt
               - fsl,imxrt1170-gpt
           - const: fsl,imx6dl-gpt