| Message ID | 20230606111042.96855-1-franziska.naepelt@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: frcypt Fix checkpatch warnings | expand |
[Also Cc: linux-spdx list and original author mentioned in the license boilerplate] On Tue, Jun 06, 2023 at 01:10:42PM +0200, Franziska Naepelt wrote: > The following checkpatch warnings have been fixed: > - WARNING: Missing or malformed SPDX-License-Identifier tag > - WARNING: Block comments use a trailing */ on a separate line Two different logical changes in a patch - please break them into a 2-patch series, with each patch do one job. And please write the patch description in imperative mood instead (e.g. "Do foo"). > +// SPDX-License-Identifier: GPL-2.0-or-later > /* FCrypt encryption algorithm > * > * Copyright (C) 2006 Red Hat, Inc. All Rights Reserved. NAK! There is also BSD 3-clause boilerplate (from original code that fcrypt.c is based on). Thus, the proper SPDX tag should have been: ``` // SPDX-License-Identifier: GPL-2.0-or-later AND BSD-3-Clause ``` And please also delete the boilerplate. Thanks.
diff --git a/crypto/fcrypt.c b/crypto/fcrypt.c index 95a16e88899b..d81d65489c41 100644 --- a/crypto/fcrypt.c +++ b/crypto/fcrypt.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* FCrypt encryption algorithm * * Copyright (C) 2006 Red Hat, Inc. All Rights Reserved. @@ -303,7 +304,8 @@ static int fcrypt_setkey(struct crypto_tfm *tfm, const u8 *key, unsigned int key #if BITS_PER_LONG == 64 /* the 64-bit version can also be used for 32-bit * kernels - it seems to be faster but the code is - * larger */ + * larger + */ u64 k; /* k holds all 56 non-parity bits */
The following checkpatch warnings have been fixed: - WARNING: Missing or malformed SPDX-License-Identifier tag - WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com> --- crypto/fcrypt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7