diff mbox series

[v8,03/14] dmaengine: idxd: Export drv_enable/disable and related functions

Message ID 20230731212939.1391453-4-tom.zanussi@linux.intel.com (mailing list archive)
State Superseded
Delegated to: Herbert Xu
Headers show
Series crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver | expand

Commit Message

Zanussi, Tom July 31, 2023, 9:29 p.m. UTC 
To allow idxd sub-drivers to enable and disable wqs, export them.

Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
---
 drivers/dma/idxd/device.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Vinod Koul Aug. 3, 2023, 1:15 p.m. UTC | #1 
On 31-07-23, 16:29, Tom Zanussi wrote:
> To allow idxd sub-drivers to enable and disable wqs, export them.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
>  drivers/dma/idxd/device.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5abbcc61c528..87ad95fa3f98 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq)
>  err:
>  	return rc;
>  }
> +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);

Sorry this is a very generic symbol, pls dont export it. I would make it
idxd_drv_enable_wq()

>  
>  void drv_disable_wq(struct idxd_wq *wq)
>  {
> @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq)
>  	wq->type = IDXD_WQT_NONE;
>  	wq->client_count = 0;
>  }
> +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
>  
>  int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
>  {
> -- 
> 2.34.1
Zanussi, Tom Aug. 3, 2023, 2:24 p.m. UTC | #2 
Hi Vinod,

On Thu, 2023-08-03 at 18:45 +0530, Vinod Koul wrote:
> On 31-07-23, 16:29, Tom Zanussi wrote:
> > To allow idxd sub-drivers to enable and disable wqs, export them.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> > ---
> >  drivers/dma/idxd/device.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> > index 5abbcc61c528..87ad95fa3f98 100644
> > --- a/drivers/dma/idxd/device.c
> > +++ b/drivers/dma/idxd/device.c
> > @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq)
> >  err:
> >         return rc;
> >  }
> > +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);
> 
> Sorry this is a very generic symbol, pls dont export it. I would make
> it
> idxd_drv_enable_wq()

Yeah, good point, I'll do that for the next version.  And thanks for
all your Acks!

Tom

> 
> >  
> >  void drv_disable_wq(struct idxd_wq *wq)
> >  {
> > @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq)
> >         wq->type = IDXD_WQT_NONE;
> >         wq->client_count = 0;
> >  }
> > +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
> >  
> >  int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
> >  {
> > -- 
> > 2.34.1
>
Dave Jiang Aug. 3, 2023, 3:24 p.m. UTC | #3 
On 8/3/23 06:15, Vinod Koul wrote:
> On 31-07-23, 16:29, Tom Zanussi wrote:
>> To allow idxd sub-drivers to enable and disable wqs, export them.
>>
>> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>> ---
>>   drivers/dma/idxd/device.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
>> index 5abbcc61c528..87ad95fa3f98 100644
>> --- a/drivers/dma/idxd/device.c
>> +++ b/drivers/dma/idxd/device.c
>> @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq)
>>   err:
>>   	return rc;
>>   }
>> +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);
> 
> Sorry this is a very generic symbol, pls dont export it. I would make it
> idxd_drv_enable_wq()

That's true. Although just a note it's only exported in the IDXD 
namespace. So maybe ok?

> 
>>   
>>   void drv_disable_wq(struct idxd_wq *wq)
>>   {
>> @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq)
>>   	wq->type = IDXD_WQT_NONE;
>>   	wq->client_count = 0;
>>   }
>> +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
>>   
>>   int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
>>   {
>> -- 
>> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 5abbcc61c528..87ad95fa3f98 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -1505,6 +1505,7 @@  int drv_enable_wq(struct idxd_wq *wq)
 err:
 	return rc;
 }
+EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);
 
 void drv_disable_wq(struct idxd_wq *wq)
 {
@@ -1526,6 +1527,7 @@  void drv_disable_wq(struct idxd_wq *wq)
 	wq->type = IDXD_WQT_NONE;
 	wq->client_count = 0;
 }
+EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
 
 int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
 {