| Message ID | 20230911120203.774632-8-gatien.chevallier@foss.st.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | hwrng: stm32: support STM32MP13x platforms | expand |
On 11/09/2023 14:02, Gatien Chevallier wrote: > If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR > and RNG_NSCR will be locked. It is supported starting from the RNG > version present in the STM32MP13 > > Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> How did you implement the comment? There is no changelog, so was it ignored? Best regards, Krzysztof
On 9/12/23 16:38, Krzysztof Kozlowski wrote: > On 11/09/2023 14:02, Gatien Chevallier wrote: >> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR >> and RNG_NSCR will be locked. It is supported starting from the RNG >> version present in the STM32MP13 >> >> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> > > How did you implement the comment? There is no changelog, so was it ignored? > > Best regards, > Krzysztof > Hello Krzysztof, I've sent V2 before Rob's review. I'll apply Rob's comment for V3. Best regards, Gatien
On 13/09/2023 09:48, Gatien CHEVALLIER wrote: > On 9/12/23 16:38, Krzysztof Kozlowski wrote: >> On 11/09/2023 14:02, Gatien Chevallier wrote: >>> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR >>> and RNG_NSCR will be locked. It is supported starting from the RNG >>> version present in the STM32MP13 >>> >>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> >> >> How did you implement the comment? There is no changelog, so was it ignored? >> >> Best regards, >> Krzysztof >> > > Hello Krzysztof, > > I've sent V2 before Rob's review. I'll apply Rob's comment for V3. Ah, ok. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml index 59abdc85a9fb..0055f14a8e3f 100644 --- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml +++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml @@ -37,6 +37,20 @@ required: - reg - clocks +allOf: + - if: + properties: + compatible: + contains: + enum: + - st,stm32mp13-rng + then: + properties: + st,rng-lock-conf: + type: boolean + description: If set, the RNG configuration in RNG_CR, RNG_HTCR and + RNG_NSCR will be locked. + additionalProperties: false examples:
If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR and RNG_NSCR will be locked. It is supported starting from the RNG version present in the STM32MP13 Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> --- .../devicetree/bindings/rng/st,stm32-rng.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+)