diff mbox series

crypto: shash - don't exclude async statuses from error stats

Message ID 20231029051659.157987-1-ebiggers@kernel.org (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series crypto: shash - don't exclude async statuses from error stats | expand

Commit Message

Eric Biggers Oct. 29, 2023, 5:16 a.m. UTC
From: Eric Biggers <ebiggers@google.com>

EINPROGRESS and EBUSY have special meaning for async operations.
However, shash is always synchronous, so these statuses have no special
meaning for shash and don't need to be excluded when handling errors.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 crypto/shash.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)


base-commit: f2b88bab69c86d4dab2bfd25a0e741d7df411f7a

Comments

Herbert Xu Nov. 17, 2023, 11:23 a.m. UTC | #1
Eric Biggers <ebiggers@kernel.org> wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> EINPROGRESS and EBUSY have special meaning for async operations.
> However, shash is always synchronous, so these statuses have no special
> meaning for shash and don't need to be excluded when handling errors.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/shash.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/crypto/shash.c b/crypto/shash.c
index d5194221c88c..c3f7f6a25280 100644
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -16,26 +16,22 @@ 
 
 #include "hash.h"
 
 static inline struct crypto_istat_hash *shash_get_stat(struct shash_alg *alg)
 {
 	return hash_get_stat(&alg->halg);
 }
 
 static inline int crypto_shash_errstat(struct shash_alg *alg, int err)
 {
-	if (!IS_ENABLED(CONFIG_CRYPTO_STATS))
-		return err;
-
-	if (err && err != -EINPROGRESS && err != -EBUSY)
+	if (IS_ENABLED(CONFIG_CRYPTO_STATS) && err)
 		atomic64_inc(&shash_get_stat(alg)->err_cnt);
-
 	return err;
 }
 
 int shash_no_setkey(struct crypto_shash *tfm, const u8 *key,
 		    unsigned int keylen)
 {
 	return -ENOSYS;
 }
 EXPORT_SYMBOL_GPL(shash_no_setkey);