| Message ID | 20240109021916.20960-1-duminjie@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init() | expand |
On Tue, 2024-01-09 at 10:19 +0800, Minjie Du wrote: > This patch removes the debugfs_create_dir() error checking in > iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is > developed > in a way that the caller can safely handle the errors that > occur during the creation of DebugFS nodes. > > Signed-off-by: Minjie Du <duminjie@vivo.com> Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com> Thanks Minjie, Tom > --- > drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c > b/drivers/crypto/intel/iaa/iaa_crypto_stats.c > index 2e3b7b73af20..cbf87d0effe3 100644 > --- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c > +++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c > @@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void) > return -ENODEV; > > iaa_crypto_debugfs_root = debugfs_create_dir("iaa_crypto", > NULL); > - if (!iaa_crypto_debugfs_root) > - return -ENOMEM; > > debugfs_create_u64("max_comp_delay_ns", 0644, > iaa_crypto_debugfs_root, > &max_comp_delay_ns);
On Tue, Jan 09, 2024 at 10:19:14AM +0800, Minjie Du wrote: > This patch removes the debugfs_create_dir() error checking in > iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is developed > in a way that the caller can safely handle the errors that > occur during the creation of DebugFS nodes. > > Signed-off-by: Minjie Du <duminjie@vivo.com> > --- > drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 -- > 1 file changed, 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c b/drivers/crypto/intel/iaa/iaa_crypto_stats.c index 2e3b7b73af20..cbf87d0effe3 100644 --- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c +++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c @@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void) return -ENODEV; iaa_crypto_debugfs_root = debugfs_create_dir("iaa_crypto", NULL); - if (!iaa_crypto_debugfs_root) - return -ENOMEM; debugfs_create_u64("max_comp_delay_ns", 0644, iaa_crypto_debugfs_root, &max_comp_delay_ns);
This patch removes the debugfs_create_dir() error checking in iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is developed in a way that the caller can safely handle the errors that occur during the creation of DebugFS nodes. Signed-off-by: Minjie Du <duminjie@vivo.com> --- drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 -- 1 file changed, 2 deletions(-)