| Message ID | 20240321210846.1307596-3-tom.zanussi@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: iaa - A couple of bugfixes | expand |
On Thu, Mar 21, 2024 at 04:08:46PM -0500, Tom Zanussi wrote: > From: Jerry Snitselaar <jsnitsel@redhat.com> > > This cleans up the following issues I ran into when trying to use the > scripts and commands in the iaa-crypto.rst document. > > - Fix incorrect arguments being passed to accel-config > config-wq. > - Replace --device_name with --driver-name. > - Replace --driver_name with --driver-name. > - Replace --size with --wq-size. > - Add missing --priority argument. > - Add missing accel-config config-engine command after the > config-wq commands. > - Fix wq name passed to accel-config config-wq. > - Add rmmod/modprobe of iaa_crypto to script that disables, > then enables all devices and workqueues to avoid enable-wq > failing with -EEXIST when trying to register to compression > algorithm. > - Fix device name in cases where iaa was used instead of iax. > > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: linux-crypto@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> > Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com> > --- > .../driver-api/crypto/iaa/iaa-crypto.rst | 22 ++++++++++++++----- > 1 file changed, 16 insertions(+), 6 deletions(-) Patch applied. Thanks.
diff --git a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst index de587cf9cbed..330d35df5f16 100644 --- a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst +++ b/Documentation/driver-api/crypto/iaa/iaa-crypto.rst @@ -179,7 +179,9 @@ has the old 'iax' device naming in place) :: # configure wq1.0 - accel-config config-wq --group-id=0 --mode=dedicated --type=kernel --name="iaa_crypto" --device_name="crypto" iax1/wq1.0 + accel-config config-wq --group-id=0 --mode=dedicated --type=kernel --priority=10 --name="iaa_crypto" --driver-name="crypto" iax1/wq1.0 + + accel-config config-engine iax1/engine1.0 --group-id=0 # enable IAA device iax1 @@ -536,12 +538,20 @@ The below script automatically does that:: echo "End Disable IAA" + echo "Reload iaa_crypto module" + + rmmod iaa_crypto + modprobe iaa_crypto + + echo "End Reload iaa_crypto module" + # # configure iaa wqs and devices # echo "Configure IAA" for ((i = 1; i < ${num_iaa} * 2; i += 2)); do - accel-config config-wq --group-id=0 --mode=dedicated --size=128 --priority=10 --type=kernel --name="iaa_crypto" --driver_name="crypto" iax${i}/wq${i} + accel-config config-wq --group-id=0 --mode=dedicated --wq-size=128 --priority=10 --type=kernel --name="iaa_crypto" --driver-name="crypto" iax${i}/wq${i}.0 + accel-config config-engine iax${i}/engine${i}.0 --group-id=0 done echo "End Configure IAA" @@ -552,10 +562,10 @@ The below script automatically does that:: echo "Enable IAA" for ((i = 1; i < ${num_iaa} * 2; i += 2)); do - echo enable iaa iaa${i} - accel-config enable-device iaa${i} - echo enable wq iaa${i}/wq${i}.0 - accel-config enable-wq iaa${i}/wq${i}.0 + echo enable iaa iax${i} + accel-config enable-device iax${i} + echo enable wq iax${i}/wq${i}.0 + accel-config enable-wq iax${i}/wq${i}.0 done echo "End Enable IAA"