Message ID | 20240328-jag-sysctl_remset_misc-v1-2-47c1463b3af2@samsung.com (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Herbert Xu |
Headers | show |
Series | [1/7] memory: Remove the now superfluous sentinel element from ctl_table array | expand |
Hey This is the only patch that I have not seen added to the next tree. I'll put this in the sysctl-next https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next for testing. Please let me know if It is lined up to be upstream through another path. Best On Thu, Mar 28, 2024 at 04:57:49PM +0100, Joel Granados via B4 Relay wrote: > From: Joel Granados <j.granados@samsung.com> > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which will > reduce the overall build time size of the kernel and run time memory > bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > ...
On Mon, Apr 15, 2024 at 9:44 AM Joel Granados <j.granados@samsung.com> wrote: > > Hey > > This is the only patch that I have not seen added to the next tree. > I'll put this in the sysctl-next > https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next > for testing. Please let me know if It is lined up to be upstream through > another path. I was hoping to see some ACKs from the associated LSM maintainers, but it's minor enough I'll go ahead and pull it into the lsm/dev tree this week. I'll send a note later when I do the merge.
On Thu, Mar 28, 2024 at 04:57:49PM +0100, Joel Granados via B4 Relay wrote: > From: Joel Granados <j.granados@samsung.com> > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which will > reduce the overall build time size of the kernel and run time memory > bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > Remove the sentinel from all files under security/ that register a > sysctl table. > > Signed-off-by: Joel Granados <j.granados@samsung.com> Acked-by: Kees Cook <keescook@chromium.org> # loadpin & yama
On Mon, Apr 15, 2024 at 10:17 AM Paul Moore <paul@paul-moore.com> wrote: > On Mon, Apr 15, 2024 at 9:44 AM Joel Granados <j.granados@samsung.com> wrote: > > > > Hey > > > > This is the only patch that I have not seen added to the next tree. > > I'll put this in the sysctl-next > > https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next > > for testing. Please let me know if It is lined up to be upstream through > > another path. > > I was hoping to see some ACKs from the associated LSM maintainers, but > it's minor enough I'll go ahead and pull it into the lsm/dev tree this > week. I'll send a note later when I do the merge. ... and now it's merged, it should be in the next cut of the linux-next tree. Thanks!
On Mon, Apr 15, 2024 at 03:02:43PM -0400, Paul Moore wrote: > On Mon, Apr 15, 2024 at 10:17 AM Paul Moore <paul@paul-moore.com> wrote: > > On Mon, Apr 15, 2024 at 9:44 AM Joel Granados <j.granados@samsung.com> wrote: > > > > > > Hey > > > > > > This is the only patch that I have not seen added to the next tree. > > > I'll put this in the sysctl-next > > > https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next > > > for testing. Please let me know if It is lined up to be upstream through > > > another path. > > > > I was hoping to see some ACKs from the associated LSM maintainers, but > > it's minor enough I'll go ahead and pull it into the lsm/dev tree this > > week. I'll send a note later when I do the merge. > > ... and now it's merged, it should be in the next cut of the > linux-next tree. Thanks! Awesome. I'll remove it from sysctl-next then to avoid any potential crashes. Thx
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index cef8c466af80..6239777090c4 100644 --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c @@ -2064,7 +2064,6 @@ static struct ctl_table apparmor_sysctl_table[] = { .mode = 0600, .proc_handler = apparmor_dointvec, }, - { } }; static int __init apparmor_init_sysctl(void) diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c index b348e1679d5d..91f000eef3ad 100644 --- a/security/keys/sysctl.c +++ b/security/keys/sysctl.c @@ -66,7 +66,6 @@ static struct ctl_table key_sysctls[] = { .extra2 = (void *) SYSCTL_INT_MAX, }, #endif - { } }; static int __init init_security_keys_sysctls(void) diff --git a/security/loadpin/loadpin.c b/security/loadpin/loadpin.c index 8e93cda130f1..93fd4d47b334 100644 --- a/security/loadpin/loadpin.c +++ b/security/loadpin/loadpin.c @@ -63,7 +63,6 @@ static struct ctl_table loadpin_sysctl_table[] = { .extra1 = SYSCTL_ONE, .extra2 = SYSCTL_ONE, }, - { } }; static void set_sysctl(bool is_writable) diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c index 49dc52b454ef..b6684a074a59 100644 --- a/security/yama/yama_lsm.c +++ b/security/yama/yama_lsm.c @@ -463,7 +463,6 @@ static struct ctl_table yama_sysctl_table[] = { .extra1 = SYSCTL_ZERO, .extra2 = &max_scope, }, - { } }; static void __init yama_init_sysctl(void) {