| Message ID | 20240616220719.26641-2-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: sun8i-ce: add Allwinner H616 support | expand |
On 17/06/2024 00:07, Andre Przywara wrote: > The Allwinner H616 has a crypto engine very similar to the one in the > H6, although all addresses in the DMA descriptors are shifted by 2 bits, > to accommodate for the larger physical address space. That makes it > incompatible to the H6 variant, and thus requires a new compatible > string. Clock wise it relies on the internal oscillator for the TRNG, > so needs all four possible clocks specified. > > Add the compatible string to the list of recognised names, and add the > H616 to list of devices requiring all four clocks. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Jun 17, 2024 at 6:08 AM Andre Przywara <andre.przywara@arm.com> wrote: > > The Allwinner H616 has a crypto engine very similar to the one in the > H6, although all addresses in the DMA descriptors are shifted by 2 bits, > to accommodate for the larger physical address space. That makes it > incompatible to the H6 variant, and thus requires a new compatible > string. Clock wise it relies on the internal oscillator for the TRNG, > so needs all four possible clocks specified. > > Add the compatible string to the list of recognised names, and add the > H616 to list of devices requiring all four clocks. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Chen-Yu Tsai <wens@csie.org>
diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml index 4287678aa79f4..da47b601c165e 100644 --- a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml @@ -18,6 +18,7 @@ properties: - allwinner,sun50i-a64-crypto - allwinner,sun50i-h5-crypto - allwinner,sun50i-h6-crypto + - allwinner,sun50i-h616-crypto reg: maxItems: 1 @@ -49,6 +50,7 @@ if: compatible: enum: - allwinner,sun20i-d1-crypto + - allwinner,sun50i-h616-crypto then: properties: clocks:
The Allwinner H616 has a crypto engine very similar to the one in the H6, although all addresses in the DMA descriptors are shifted by 2 bits, to accommodate for the larger physical address space. That makes it incompatible to the H6 variant, and thus requires a new compatible string. Clock wise it relies on the internal oscillator for the TRNG, so needs all four possible clocks specified. Add the compatible string to the list of recognised names, and add the H616 to list of devices requiring all four clocks. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 2 ++ 1 file changed, 2 insertions(+)