diff mbox series

[v8,6/6] Add SPAcc compilation in crypto

Message ID 20240905113050.237789-7-pavitrakumarm@vayavyalabs.com (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show
Series Add SPAcc Crypto Driver | expand

Commit Message

Pavitrakumar Managutte Sept. 5, 2024, 11:30 a.m. UTC 
Add SPAcc compilation to crypto subsystem.

Signed-off-by: Bhoomika K <bhoomikak@vayavyalabs.com>
Signed-off-by: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
Acked-by: Ruud Derwig <Ruud.Derwig@synopsys.com>
---
 drivers/crypto/Kconfig  | 1 +
 drivers/crypto/Makefile | 1 +
 2 files changed, 2 insertions(+)

Comments

kernel test robot Sept. 6, 2024, 4:25 p.m. UTC | #1 
Hi Pavitrakumar,

kernel test robot noticed the following build errors:

[auto build test ERROR on b8fc70ab7b5f3afbc4fb0587782633d7fcf1e069]

url:    https://github.com/intel-lab-lkp/linux/commits/Pavitrakumar-M/Add-SPAcc-Skcipher-support/20240905-193246
base:   b8fc70ab7b5f3afbc4fb0587782633d7fcf1e069
patch link:    https://lore.kernel.org/r/20240905113050.237789-7-pavitrakumarm%40vayavyalabs.com
patch subject: [PATCH v8 6/6] Add SPAcc compilation in crypto
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240906/202409062336.4TasntvL-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240906/202409062336.4TasntvL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409062336.4TasntvL-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/crypto/dwc-spacc/spacc_device.h:10,
                    from drivers/crypto/dwc-spacc/spacc_skcipher.c:10:
>> drivers/crypto/dwc-spacc/spacc_core.h:736:31: error: field 'pop_jobs' has incomplete type
     736 |         struct tasklet_struct pop_jobs;
         |                               ^~~~~~~~


vim +/pop_jobs +736 drivers/crypto/dwc-spacc/spacc_core.h

450b68890aff16 Pavitrakumar M 2024-09-05  732  
450b68890aff16 Pavitrakumar M 2024-09-05  733  struct spacc_priv {
450b68890aff16 Pavitrakumar M 2024-09-05  734  	struct spacc_device spacc;
450b68890aff16 Pavitrakumar M 2024-09-05  735  	struct semaphore core_running;
450b68890aff16 Pavitrakumar M 2024-09-05 @736  	struct tasklet_struct pop_jobs;
450b68890aff16 Pavitrakumar M 2024-09-05  737  	spinlock_t hw_lock;
450b68890aff16 Pavitrakumar M 2024-09-05  738  	unsigned long max_msg_len;
450b68890aff16 Pavitrakumar M 2024-09-05  739  };
450b68890aff16 Pavitrakumar M 2024-09-05  740  
450b68890aff16 Pavitrakumar M 2024-09-05  741
diff mbox series

Patch

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 94f23c6fc93b..009cbd0e1993 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -696,6 +696,7 @@  config CRYPTO_DEV_BCM_SPU
 	  ahash, and aead algorithms with the kernel cryptographic API.
 
 source "drivers/crypto/stm32/Kconfig"
+source "drivers/crypto/dwc-spacc/Kconfig"
 
 config CRYPTO_DEV_SAFEXCEL
 	tristate "Inside Secure's SafeXcel cryptographic engine driver"
diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
index ad4ccef67d12..a937e8f5849b 100644
--- a/drivers/crypto/Makefile
+++ b/drivers/crypto/Makefile
@@ -48,6 +48,7 @@  obj-$(CONFIG_CRYPTO_DEV_BCM_SPU) += bcm/
 obj-$(CONFIG_CRYPTO_DEV_SAFEXCEL) += inside-secure/
 obj-$(CONFIG_CRYPTO_DEV_ARTPEC6) += axis/
 obj-y += xilinx/
+obj-y += dwc-spacc/
 obj-y += hisilicon/
 obj-$(CONFIG_CRYPTO_DEV_AMLOGIC_GXL) += amlogic/
 obj-y += intel/