Message ID | 20250114141203.1421-1-tanyaagarwal25699@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Herbert Xu |
Headers | show |
Series | [RESEND,V3] lib: 842: Improve error handling in sw842_compress() | expand |
On Tue, Jan 14, 2025 at 07:42:04PM +0530, Tanya Agarwal wrote: > From: Tanya Agarwal <tanyaagarwal25699@gmail.com> > > The static code analysis tool "Coverity Scan" pointed the following > implementation details out for further development considerations: > CID 1309755: Unused value > In sw842_compress: A value assigned to a variable is never used. (CWE-563) > returned_value: Assigning value from add_repeat_template(p, repeat_count) > to ret here, but that stored value is overwritten before it can be used. > > Conclusion: > Add error handling for the return value from an add_repeat_template() > call. > > Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com> > --- > V3: update title and reorganize commit description > V2: add Fixes tag and reword commit description > > Coverity Link: > https://scan5.scan.coverity.com/#/project-view/63683/10063?selectedIssue=1309755 > > lib/842/842_compress.c | 2 ++ > 1 file changed, 2 insertions(+) Patch applied. Thanks.
diff --git a/lib/842/842_compress.c b/lib/842/842_compress.c index c02baa4168e1..055356508d97 100644 --- a/lib/842/842_compress.c +++ b/lib/842/842_compress.c @@ -532,6 +532,8 @@ int sw842_compress(const u8 *in, unsigned int ilen, } if (repeat_count) { ret = add_repeat_template(p, repeat_count); + if (ret) + return ret; repeat_count = 0; if (next == last) /* reached max repeat bits */ goto repeat;