From patchwork Wed Mar 26 15:59:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Giovanni Cabiddu X-Patchwork-Id: 14030249 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585151F5402; Wed, 26 Mar 2025 16:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743004911; cv=none; b=OXcCj+qiziOBCM22Lxx9AySILui0lA+azS3UiesmxZixfyJzodQjnMpcsSvWOljhHyRGCmwc2J/l0VcbEbJrsY/E5l4CWh3yyFVdDTFsVZ4W+J/SgTCrpRqBBYaXHc6SrEpdd0AhKcbDfmqqR9uWTsQaV44MYnZcukRpbTBVVks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743004911; c=relaxed/simple; bh=W2HVQ8BEyML65PSTZrKfO0xXPcysyzh4Hk5b82bfqRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VHhrBt/WVo2AX+vkmLM+9GoBcUYE8MFc2iSKmaGwfX7u8C17S84qS+MtkjLcEYNDqAXfldYZwN6MA6yjtoVCc6rwy9WwBc5L1z8D8+JIQqHqH8iOXgZi0w6xVDR/vqRNuBhmzSmsn2N/qn4dR8z3SvH9FfnRak6WOP54E1zUVyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=g4xMvjbH; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="g4xMvjbH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743004910; x=1774540910; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W2HVQ8BEyML65PSTZrKfO0xXPcysyzh4Hk5b82bfqRY=; b=g4xMvjbHbzJbZ7KZKa2Km6dlcmvXfHRA1168ChE0Tkg+R4Tp0hYOD2VO WOBfxJaL15QXrHfnao3XRyFXG+WFlWTJv42NB2Fbq3+Dd6nWTN5ty7oTi VS/Y4UZ3+E+wAiTfyXO4XYQMd96D0ji7MahSBdxcaN+Oz27X3m374zNpR zU7yNVnobBiha/6syf4pAs+FQzRLvXoeLmxJ+7hyv7NjOnlITfeb433c8 5m4VPygS0awwZcP9cC5WsZaRyVXL3Q7oFFUXBZ8bMO4xDM1bVnlzq2+/e Ih/AF1/GtWB++sS50aRrI4SxjCAWEg0nToC/oOnET8hKH3OfcWWUlrD32 A==; X-CSE-ConnectionGUID: jhaDyXO2S1+jUkfZ2FgC3A== X-CSE-MsgGUID: vVaveV7xSLqgyYu7cSNMJg== X-IronPort-AV: E=McAfee;i="6700,10204,11385"; a="61823893" X-IronPort-AV: E=Sophos;i="6.14,278,1736841600"; d="scan'208";a="61823893" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2025 09:01:50 -0700 X-CSE-ConnectionGUID: Qg7S4ycaROizp+tLbZ4LKw== X-CSE-MsgGUID: ZfjPEkCaQfeOVW///m1NZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,278,1736841600"; d="scan'208";a="129928576" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314.ger.corp.intel.com) ([10.237.223.204]) by fmviesa004.fm.intel.com with ESMTP; 26 Mar 2025 09:01:48 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, andriy.shevchenko@intel.com, qat-linux@intel.com, Giovanni Cabiddu , stable@vger.kernel.org, Ahsan Atta , Andy Shevchenko Subject: [PATCH 4/8] crypto: qat - add shutdown handler to qat_dh895xcc Date: Wed, 26 Mar 2025 15:59:49 +0000 Message-ID: <20250326160116.102699-6-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250326160116.102699-2-giovanni.cabiddu@intel.com> References: <20250326160116.102699-2-giovanni.cabiddu@intel.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland During a warm reset via kexec, the system bypasses the driver removal sequence, meaning that the remove() callback is not invoked. If a QAT device is not shutdown properly, the device driver will fail to load in a newly rebooted kernel. This might result in output like the following after the kexec reboot: QAT: AE0 is inactive!! QAT: failed to get device out of reset dh895xcc 0000:3f:00.0: qat_hal_clr_reset error dh895xcc 0000:3f:00.0: Failed to init the AEs dh895xcc 0000:3f:00.0: Failed to initialise Acceleration Engine dh895xcc 0000:3f:00.0: Resetting device qat_dev0 dh895xcc 0000:3f:00.0: probe with driver dh895xcc failed with error -14 Implement the shutdown() handler that hooks into the reboot notifier list. This brings down the QAT device and ensures it is shut down properly. Cc: Fixes: 7afa232e76ce ("crypto: qat - Intel(R) QAT DH895xcc accelerator") Reviewed-by: Ahsan Atta Reviewed-by: Andy Shevchenko Signed-off-by: Giovanni Cabiddu --- drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c index 730147404ceb..b59e0cc49e52 100644 --- a/drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c +++ b/drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c @@ -209,6 +209,13 @@ static void adf_remove(struct pci_dev *pdev) kfree(accel_dev); } +static void adf_shutdown(struct pci_dev *pdev) +{ + struct adf_accel_dev *accel_dev = adf_devmgr_pci_to_accel_dev(pdev); + + adf_dev_down(accel_dev); +} + static const struct pci_device_id adf_pci_tbl[] = { { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_QAT_DH895XCC) }, { } @@ -220,6 +227,7 @@ static struct pci_driver adf_driver = { .name = ADF_DH895XCC_DEVICE_NAME, .probe = adf_probe, .remove = adf_remove, + .shutdown = adf_shutdown, .sriov_configure = adf_sriov_configure, .err_handler = &adf_err_handler, };