| Message ID | 20250411192053.461263-2-thorsten.blum@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: skcipher - Realign struct skcipher_walk to save 8 bytes | expand |
On Fri, Apr 11, 2025 at 09:20:51PM +0200, Thorsten Blum wrote: > Reduce skcipher_walk's struct size by 8 bytes by realigning its members. > > pahole output before: > > /* size: 120, cachelines: 2, members: 13 */ > /* sum members: 108, holes: 2, sum holes: 8 */ > /* padding: 4 */ > /* last cacheline: 56 bytes */ > > and after: > > /* size: 112, cachelines: 2, members: 13 */ > /* padding: 4 */ > /* last cacheline: 48 bytes */ > > No functional changes intended. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> > --- > include/crypto/internal/skcipher.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/include/crypto/internal/skcipher.h b/include/crypto/internal/skcipher.h index a958ab0636ad..0cad8e7364c8 100644 --- a/include/crypto/internal/skcipher.h +++ b/include/crypto/internal/skcipher.h @@ -67,8 +67,6 @@ struct skcipher_walk { struct scatter_walk in; }; - unsigned int nbytes; - union { /* Virtual address of the destination. */ struct { @@ -81,6 +79,7 @@ struct skcipher_walk { struct scatter_walk out; }; + unsigned int nbytes; unsigned int total; u8 *page;
Reduce skcipher_walk's struct size by 8 bytes by realigning its members. pahole output before: /* size: 120, cachelines: 2, members: 13 */ /* sum members: 108, holes: 2, sum holes: 8 */ /* padding: 4 */ /* last cacheline: 56 bytes */ and after: /* size: 112, cachelines: 2, members: 13 */ /* padding: 4 */ /* last cacheline: 48 bytes */ No functional changes intended. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- include/crypto/internal/skcipher.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)