| Message ID | 2a313cc6de53c492db10e29c6444d8e6f2529689.1636735696.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: ccree - remove redundant 'flush_workqueue()' calls | expand |
On Fri, Nov 12, 2021 at 05:49:23PM +0100, Christophe JAILLET wrote: > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: Hi Cristophe, > > @@ > expression E; > @@ > - flush_workqueue(E); > destroy_workqueue(E); > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> LGTM. Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Thanks, Cristian > --- > drivers/crypto/ccree/cc_request_mgr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c > index 33fb27745d52..887162df50f9 100644 > --- a/drivers/crypto/ccree/cc_request_mgr.c > +++ b/drivers/crypto/ccree/cc_request_mgr.c > @@ -101,7 +101,6 @@ void cc_req_mgr_fini(struct cc_drvdata *drvdata) > dev_dbg(dev, "max_used_sw_slots=%d\n", req_mgr_h->max_used_sw_slots); > > #ifdef COMP_IN_WQ > - flush_workqueue(req_mgr_h->workq); > destroy_workqueue(req_mgr_h->workq); > #else > /* Kill tasklet */ > -- > 2.30.2 >
On Fri, Nov 12, 2021 at 6:49 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > - flush_workqueue(E); > destroy_workqueue(E); > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/crypto/ccree/cc_request_mgr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c > index 33fb27745d52..887162df50f9 100644 > --- a/drivers/crypto/ccree/cc_request_mgr.c > +++ b/drivers/crypto/ccree/cc_request_mgr.c > @@ -101,7 +101,6 @@ void cc_req_mgr_fini(struct cc_drvdata *drvdata) > dev_dbg(dev, "max_used_sw_slots=%d\n", req_mgr_h->max_used_sw_slots); > > #ifdef COMP_IN_WQ > - flush_workqueue(req_mgr_h->workq); > destroy_workqueue(req_mgr_h->workq); > #else > /* Kill tasklet */ > -- > 2.30.2 > Acked-by: Gilad Ben-Yossef <gilad@benyossef.com> Thank you for finding ths. Also, this triggers me to revisit why the workqueue code is there at all. I think we don't actually use it, so double thanks. Gilad
On Fri, Nov 12, 2021 at 05:49:23PM +0100, Christophe JAILLET wrote: > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > - flush_workqueue(E); > destroy_workqueue(E); > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/crypto/ccree/cc_request_mgr.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c index 33fb27745d52..887162df50f9 100644 --- a/drivers/crypto/ccree/cc_request_mgr.c +++ b/drivers/crypto/ccree/cc_request_mgr.c @@ -101,7 +101,6 @@ void cc_req_mgr_fini(struct cc_drvdata *drvdata) dev_dbg(dev, "max_used_sw_slots=%d\n", req_mgr_h->max_used_sw_slots); #ifdef COMP_IN_WQ - flush_workqueue(req_mgr_h->workq); destroy_workqueue(req_mgr_h->workq); #else /* Kill tasklet */
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/crypto/ccree/cc_request_mgr.c | 1 - 1 file changed, 1 deletion(-)