From patchwork Tue Oct 17 13:42:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Mueller X-Patchwork-Id: 10012091 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 56A12601E7 for ; Tue, 17 Oct 2017 13:47:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FD7E288E0 for ; Tue, 17 Oct 2017 13:47:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4465D288E4; Tue, 17 Oct 2017 13:47:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B0B70288E0 for ; Tue, 17 Oct 2017 13:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757520AbdJQNrr (ORCPT ); Tue, 17 Oct 2017 09:47:47 -0400 Received: from mail.eperm.de ([89.247.134.16]:34926 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbdJQNrr (ORCPT ); Tue, 17 Oct 2017 09:47:47 -0400 Received: from tauon.chronox.de (66-146-167-162.skyriver.net [66.146.167.162]) by mail.eperm.de (Postfix) with ESMTPSA id B744418160CA; Tue, 17 Oct 2017 15:47:44 +0200 (CEST) From: Stephan Mueller To: Christophe LEROY Cc: "linux-crypto@vger.kernel.org" Subject: Re: md5sum (from libkcapi) fails on kernel 4.9 but not on 4.13 Date: Tue, 17 Oct 2017 15:42:31 +0200 Message-ID: <3299215.QY4dUA6yAn@tauon.chronox.de> In-Reply-To: <3fc056b8-690c-6cec-3af6-0e6d55f4628c@c-s.fr> References: <5c552c4b-c05e-7098-6e60-fdc6f7ed5d4b@c-s.fr> <64a7edb0-b9c0-32cd-cc6e-096f2911d5bc@c-s.fr> <3fc056b8-690c-6cec-3af6-0e6d55f4628c@c-s.fr> MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Am Dienstag, 17. Oktober 2017, 10:51:06 CEST schrieb Christophe LEROY: Hi Christophe, > > I've now tried a test with 1.0.0, and there seems to be another big > issue: the error returned by sendmsg() is not taken into account anymore: It seems that this bug was there before. Can you please check whether this one fixes it? ret = vmsplice(handle->pipes[1], &iov, 1, SPLICE_F_GIFT|flags); Thanks Ciao Stephan diff --git a/lib/kcapi-kernel-if.c b/lib/kcapi-kernel-if.c index e00d328..9053104 100644 --- a/lib/kcapi-kernel-if.c +++ b/lib/kcapi-kernel-if.c @@ -321,6 +321,8 @@ int32_t _kcapi_common_vmsplice_chunk_fd(struct kcapi_handle *handle, int *fdptr, if ((handle->processed_sg++) > handle->flags.alg_max_pages) { ret = _kcapi_common_send_data(handle, &iov, 1, sflags); + if (ret < 0) + return ret; } else {