From patchwork Tue Aug 11 18:05:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tadeusz Struk X-Patchwork-Id: 6994171 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EE211C05AC for ; Tue, 11 Aug 2015 18:07:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 24E6320553 for ; Tue, 11 Aug 2015 18:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B95B92054E for ; Tue, 11 Aug 2015 18:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932128AbbHKSHA (ORCPT ); Tue, 11 Aug 2015 14:07:00 -0400 Received: from mga02.intel.com ([134.134.136.20]:9592 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbbHKSG7 (ORCPT ); Tue, 11 Aug 2015 14:06:59 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 11 Aug 2015 11:06:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,654,1432623600"; d="scan'208";a="539933260" Received: from tstruk-mobl1.jf.intel.com (HELO tstruk-mobl1.intel.com) ([134.134.171.74]) by FMSMGA003.fm.intel.com with ESMTP; 11 Aug 2015 11:06:41 -0700 Message-ID: <55CA3971.5070008@intel.com> Date: Tue, 11 Aug 2015 11:05:37 -0700 From: Tadeusz Struk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Herbert Xu CC: kbuild test robot , kbuild-all@01.org, linux-crypto@vger.kernel.org Subject: Re: [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) References: <201508110049.yV4f3Yls%fengguang.wu@intel.com> <55C8E2E9.8000509@intel.com> <20150811135738.GA30846@gondor.apana.org.au> In-Reply-To: <20150811135738.GA30846@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/11/2015 06:57 AM, Herbert Xu wrote: > On Mon, Aug 10, 2015 at 10:44:09AM -0700, Tadeusz Struk wrote: >> > >> > config CRYPTO_DEV_QAT_DH895xCCVF >> > tristate "Support for Intel(R) DH895xCC Virtual Function" >> > + select PCI >> > select PCI_IOV > Wouldn't a dependency on PCI make more sense? Or does this not > work? Yes, you are right. This is how it is in the PF config. It also needs to select the qat common code. ---8<--- Fix unmet direct dependencies for QAT_DH895xCCVF Reported-by: Fengguang Wu Signed-off-by: Tadeusz Struk --- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig index 95a9566..eefccf7 100644 --- a/drivers/crypto/qat/Kconfig +++ b/drivers/crypto/qat/Kconfig @@ -24,7 +24,9 @@ config CRYPTO_DEV_QAT_DH895xCC config CRYPTO_DEV_QAT_DH895xCCVF tristate "Support for Intel(R) DH895xCC Virtual Function" + depends on X86 && PCI select PCI_IOV + select CRYPTO_DEV_QAT help Support for Intel(R) DH895xcc with Intel(R) QuickAssist Technology