From patchwork Sun Dec 20 16:53:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tadeusz Struk X-Patchwork-Id: 7892281 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4FE5CBEEED for ; Sun, 20 Dec 2015 16:54:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6CD842039D for ; Sun, 20 Dec 2015 16:54:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BDAF203AD for ; Sun, 20 Dec 2015 16:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933041AbbLTQxQ (ORCPT ); Sun, 20 Dec 2015 11:53:16 -0500 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36592 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbbLTQxO (ORCPT ); Sun, 20 Dec 2015 11:53:14 -0500 Received: by mail-pa0-f65.google.com with SMTP id jx14so6047170pad.3; Sun, 20 Dec 2015 08:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=2jdgyG2Kt0hzBgDwp0iutH20rJIZ5KgqlaUT+wtTh0E=; b=HreCbchoZEgCgf0fKVDbVL6Q4Hiiu8SdzramWc9OglBcQYFz7mvjOIDc1aOTn9rTDh VqKXYF6LlyjiM+KXf4hCVRbG6S9jDTE06GApyAhsTW2To2A9SfCSoEYQwnrQac3hgoet emLGUhIVz923J3l9U9M6vp2TfOi47le1XVHAIJ83qvin6GdZZ/9LgunATyaVRnMmdF+D EaQDVVFliUbzLq6CroQde++gpxKL08SgjMF2OWL9BeUTta8TMbZrz+0Q395WM4bw/rwX YK8w/6Fg8FCQZxMbA4oJ6+MNjxBV3+79nk+s7PPBCAS98tFD+VEhTLUyx7/3JDmHhcZZ fAag== X-Received: by 10.66.62.137 with SMTP id y9mr21013250par.123.1450630394202; Sun, 20 Dec 2015 08:53:14 -0800 (PST) Received: from desktop.home (c-67-170-172-245.hsd1.or.comcast.net. [67.170.172.245]) by smtp.googlemail.com with ESMTPSA id 24sm23806822pfj.16.2015.12.20.08.53.13 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Dec 2015 08:53:13 -0800 (PST) Subject: Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher api To: kbuild test robot References: <201512200735.x3U85zQL%fengguang.wu@intel.com> Cc: Tadeusz Struk , kbuild-all@01.org, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com From: Tadeusz Struk X-Enigmail-Draft-Status: N1110 Message-ID: <5676DCF8.8060705@gmail.com> Date: Sun, 20 Dec 2015 08:53:12 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <201512200735.x3U85zQL%fengguang.wu@intel.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 12/19/2015 03:49 PM, kbuild test robot wrote: > Hi Tadeusz, > > [auto build test ERROR on crypto/master] > [also build test ERROR on v4.4-rc5 next-20151218] > > url: https://github.com/0day-ci/linux/commits/Tadeusz-Struk/crypto-KEYS-convert-public-key-to-akcipher-api/20151213-103429 > base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master > config: x86_64-randconfig-s4-12200710 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All errors (new ones prefixed by >>): > > In file included from include/crypto/public_key.h:17:0, > from include/linux/verify_pefile.h:15, > from arch/x86/kernel/kexec-bzimage64.c:22: > include/keys/asymmetric-type.h: In function 'asymmetric_key_ids': >>> >> include/keys/asymmetric-type.h:74:12: error: dereferencing pointer to incomplete type 'const struct key' > return key->payload.data[asym_key_ids]; > ^ > > vim +74 include/keys/asymmetric-type.h > > 7901c1a8 David Howells 2014-09-16 68 size_t len_1, > 7901c1a8 David Howells 2014-09-16 69 const void *val_2, > 7901c1a8 David Howells 2014-09-16 70 size_t len_2); > 146aa8b1 David Howells 2015-10-21 71 static inline > 146aa8b1 David Howells 2015-10-21 72 const struct asymmetric_key_ids *asymmetric_key_ids(const struct key *key) > 146aa8b1 David Howells 2015-10-21 73 { > 146aa8b1 David Howells 2015-10-21 @74 return key->payload.data[asym_key_ids]; > 146aa8b1 David Howells 2015-10-21 75 } > 7901c1a8 David Howells 2014-09-16 76 > 7901c1a8 David Howells 2014-09-16 77 /* > > :::::: The code at line 74 was first introduced by commit > :::::: 146aa8b1453bd8f1ff2304ffb71b4ee0eb9acdcc KEYS: Merge the type-specific data with the payload data > > :::::: TO: David Howells > :::::: CC: David Howells I think there is something missing in this configuration. cat .config | grep KEXEC_BZIMAGE_VERIFY_SIG gives nothing. Anyways, this patch should fix it. ---8<--- From: Tadeusz Struk Fix auto build test ERROR on crypto/master Reported-by: Signed-off-by: Tadeusz Struk --- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c index 0f8a6bb..23aa625 100644 --- a/arch/x86/kernel/kexec-bzimage64.c +++ b/arch/x86/kernel/kexec-bzimage64.c @@ -19,9 +19,10 @@ #include #include #include +#ifdef CONFIG_KEXEC_BZIMAGE_VERIFY_SIG #include #include - +#endif #include #include #include